Netdev List
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Andy Duan <fugang.duan@nxp.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in brcmf_sdiod_sglist_rw.
Date: Wed, 14 Nov 2018 09:39:30 +0100	[thread overview]
Message-ID: <9667eb4f-36a1-0439-867b-1defc5946bc2@broadcom.com> (raw)
In-Reply-To: <VI1PR0402MB36009CD578B9CDBF4449130FFFC30@VI1PR0402MB3600.eurprd04.prod.outlook.com>

On 11/14/2018 4:28 AM, Andy Duan wrote:
> From: David Miller <davem@davemloft.net> Sent: 2018年11月11日 8:34
>> [ As I am trying to remove direct SKB list pointer accesses I am
>>   committing this to net-next.  If this causes a lot of grief I
>>   can and will revert, just let me know. ]

[...]

>
> I just have bcm4339 in hands, test the patch on i.MX7D sdb board with bcm4339, it works fine with iperf testing.
>
> Tested-by: Fugang Duan <fugang.duan@nxp.com>

Thanks, Andy

Can you do one more check? Please insert brcmfmac with module parameter 
debug=2 and let me know if the following log message is seen:

brcmfmac: brcmf_sdiod_sgtable_alloc: nents=X

If not seen, the driver does not go through the patched code.

Regards,
Arend

  reply	other threads:[~2018-11-14 18:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11  0:34 [PATCH] brcmfmac: Use standard SKB list accessors in brcmf_sdiod_sglist_rw David Miller
     [not found] ` <20181110.163402.130407398146253939.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2018-11-13 11:19   ` Kalle Valo
2018-11-13 21:07     ` Arend van Spriel
2018-11-14  3:28 ` Andy Duan
2018-11-14  8:39   ` Arend van Spriel [this message]
2018-11-14 10:54     ` Andy Duan
2018-11-14 10:57       ` Arend van Spriel
     [not found]         ` <6679c7f3-9df2-1eb0-6f0d-725717460a82-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2018-11-14 11:29           ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9667eb4f-36a1-0439-867b-1defc5946bc2@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=fugang.duan@nxp.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox