From: shaozhengchao <shaozhengchao@huawei.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<jhs@mojatatu.com>, <jiri@resnulli.us>, <martin.lau@linux.dev>,
<daniel@iogearbox.net>, <john.fastabend@gmail.com>,
<ast@kernel.org>, <andrii@kernel.org>, <song@kernel.org>,
<yhs@fb.com>, <kpsingh@kernel.org>, <sdf@google.com>,
<haoluo@google.com>, <jolsa@kernel.org>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action_ops
Date: Thu, 8 Sep 2022 14:04:36 +0800 [thread overview]
Message-ID: <9673fd54-a11a-369c-83e4-4a0a4236be74@huawei.com> (raw)
In-Reply-To: <YxjQ0Pyz74xVLFBC@pop-os.localdomain>
On 2022/9/8 1:11, Cong Wang wrote:
> On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote:
>> diff --git a/include/net/act_api.h b/include/net/act_api.h
>> index 9cf6870b526e..86253f8b69a3 100644
>> --- a/include/net/act_api.h
>> +++ b/include/net/act_api.h
>> @@ -113,6 +113,7 @@ struct tc_action_ops {
>> enum tca_id id; /* identifier should match kind */
>> size_t size;
>> struct module *owner;
>> + unsigned int net_id;
>> int (*act)(struct sk_buff *, const struct tc_action *,
>> struct tcf_result *); /* called under RCU BH lock*/
>> int (*dump)(struct sk_buff *, struct tc_action *, int, int);
>
> This _might_ introduce some unnecessary hole in this struct, could you
> check pahole output?
>
> Thanks.
Hi Wang:
Thank you for your review. I have send v3. And I'll pay
attention next time.
Zhengchao Shao
next prev parent reply other threads:[~2022-09-08 6:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:13 [PATCH net-next,v2 00/22] refactor the walk and lookup hook functions in tc_action_ops Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action_ops Zhengchao Shao
2022-09-07 17:11 ` Cong Wang
2022-09-08 6:04 ` shaozhengchao [this message]
2022-09-06 12:13 ` [PATCH net-next,v2 02/22] net: sched: act_api: implement generic walker and search for tc action Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 03/22] net: sched: act_bpf: get rid of tcf_bpf_walker and tcf_bpf_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 04/22] net: sched: act_connmark: get rid of tcf_connmark_walker and tcf_connmark_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 05/22] net: sched: act_csum: get rid of tcf_csum_walker and tcf_csum_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 06/22] net: sched: act_ct: get rid of tcf_ct_walker and tcf_ct_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 07/22] net: sched: act_ctinfo: get rid of tcf_ctinfo_walker and tcf_ctinfo_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 08/22] net: sched: act_gact: get rid of tcf_gact_walker and tcf_gact_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 09/22] net: sched: act_gate: get rid of tcf_gate_walker and tcf_gate_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 10/22] net: sched: act_ife: get rid of tcf_ife_walker and tcf_ife_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 11/22] net: sched: act_ipt: get rid of tcf_ipt_walker/tcf_xt_walker and tcf_ipt_search/tcf_xt_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 12/22] net: sched: act_mirred: get rid of tcf_mirred_walker and tcf_mirred_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 13/22] net: sched: act_mpls: get rid of tcf_mpls_walker and tcf_mpls_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 14/22] net: sched: act_nat: get rid of tcf_nat_walker and tcf_nat_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 15/22] net: sched: act_pedit: get rid of tcf_pedit_walker and tcf_pedit_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 16/22] net: sched: act_police: get rid of tcf_police_walker and tcf_police_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 17/22] net: sched: act_sample: get rid of tcf_sample_walker and tcf_sample_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 18/22] net: sched: act_simple: get rid of tcf_simp_walker and tcf_simp_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 19/22] net: sched: act_skbedit: get rid of tcf_skbedit_walker and tcf_skbedit_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 20/22] net: sched: act_skbmod: get rid of tcf_skbmod_walker and tcf_skbmod_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 21/22] net: sched: act_tunnel_key: get rid of tunnel_key_walker and tunnel_key_search Zhengchao Shao
2022-09-06 12:13 ` [PATCH net-next,v2 22/22] net: sched: act_vlan: get rid of tcf_vlan_walker and tcf_vlan_search Zhengchao Shao
2022-09-07 15:03 ` [PATCH net-next,v2 00/22] refactor the walk and lookup hook functions in tc_action_ops Jamal Hadi Salim
2022-09-07 17:25 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9673fd54-a11a-369c-83e4-4a0a4236be74@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yhs@fb.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox