From mboxrd@z Thu Jan  1 00:00:00 1970
From: "lipeng (Y)" <lipeng321@huawei.com>
Subject: Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps
 number
Date: Wed, 20 Dec 2017 14:15:51 +0800
Message-ID: <96a532c2-c557-532f-7bfe-29301977bb5a@huawei.com>
References: <1513656159-127589-1-git-send-email-lipeng321@huawei.com>
 <1513656159-127589-3-git-send-email-lipeng321@huawei.com>
 <20171219.141840.1031328928935244349.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20171219.141840.1031328928935244349.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org



On 2017/12/20 3:18, David Miller wrote:
> From: Lipeng <lipeng321@huawei.com>
> Date: Tue, 19 Dec 2017 12:02:24 +0800
>
>> @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv)
>>   	return ret;
>>   }
>>   
>> +static void hns3_put_ring_config(struct hns3_nic_priv *priv)
>> +{
>> +	struct hnae3_handle *h = priv->ae_handle;
>> +	u16 i;
>> +
>> +	for (i = 0; i < h->kinfo.num_tqps; i++) {
> Please use a plain "int" for index iteration loops like this since
> that is the canonical type to use.
will check and fix this , Thanks.
>> +static void hclge_release_tqp(struct hclge_vport *vport)
>> +{
>> +	struct hnae3_knic_private_info *kinfo = &vport->nic.kinfo;
>> +	struct hclge_dev *hdev = vport->back;
>> +	u16 i;
>> +
>> +	for (i = 0; i < kinfo->num_tqps; i++) {
> Likewise.
>
> .
>