From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5331F132C38 for ; Wed, 15 Jan 2025 22:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736979079; cv=none; b=tROru/IgMjW0QTPYU0d8cdje0IHoX3hxcJ7vsIgwVyigBnKInnoDK3kCiURsDaUcOyy6WE27n+5ioW1ZZ11h8EY9VkAaBkZPjm28jX9e00xMsaSo8gK0BhYA9uoHpdDXirdTDcpAYGWFGJDveGh8A6TeF583Gk9s+ip+Y3seLOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736979079; c=relaxed/simple; bh=2HvmyCLKsllrJAtQaoW5j+0UXwvggo8fZ5Pq+9buQlU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l9CW2U5NCmJWI/ZfRiMyIZznt1sIEtQ9zo+G+fIT2MukHp6+r4VJE5oTkM1Y28APRGyNcAyRsB12KX529yd+FSdLC4OIc14C8it8kdO6KB0AUDQRopwUNfCstGVe9GGiDlvnVfxDCHOSs59OiZCrN/t0ae3B2QVsA0EsIhQ5E2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cbIzWtaI; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cbIzWtaI" Message-ID: <96b5bf3f-b99d-46ac-a22c-754582020c17@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736979075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZeuF7Ba0Q9yT6HX+wb3/FL7TqxwpcmPs82oCf2VVtE=; b=cbIzWtaIT7uPxwyqC4RtNIqSnyETerTKroP4/tTYPAr9/eU4Kl7U9l/U0kC3ZOtnMHTcfq qFEOwYLkM/wTX45jZbfJMR6VAkgiVvv2pmWDr+6Uw2/+Jp/YsqHq4VG/4GRyQFAL2m4pgN L20ZdS25eoDYpYBBuGzUf31UywR2t+o= Date: Wed, 15 Jan 2025 14:11:07 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v5 06/15] net-timestamp: prepare for isolating two modes of SO_TIMESTAMPING To: Jason Xing Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, willemdebruijn.kernel@gmail.com, willemb@google.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, horms@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org References: <20250112113748.73504-1-kerneljasonxing@gmail.com> <20250112113748.73504-7-kerneljasonxing@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau Content-Language: en-US In-Reply-To: <20250112113748.73504-7-kerneljasonxing@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/12/25 3:37 AM, Jason Xing wrote: > void __skb_tstamp_tx(struct sk_buff *orig_skb, > const struct sk_buff *ack_skb, > struct skb_shared_hwtstamps *hwtstamps, > - struct sock *sk, int tstype) > + struct sock *sk, bool sw, int tstype) Instead of adding a new "bool sw" and changing all callers, is it the same as testing "!hwtstamps" ?