From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63A3C4360F for ; Tue, 26 Mar 2019 18:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA64220866 for ; Tue, 26 Mar 2019 18:28:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9y91cm2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732772AbfCZS2e (ORCPT ); Tue, 26 Mar 2019 14:28:34 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34143 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732726AbfCZS2b (ORCPT ); Tue, 26 Mar 2019 14:28:31 -0400 Received: by mail-wr1-f67.google.com with SMTP id p10so15616426wrq.1 for ; Tue, 26 Mar 2019 11:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vHHu3NzC4I8VKiUc3z+22fu1gPCGvjYgIzzKU/AhOx0=; b=d9y91cm2sEBSU8mk56KoqF6Rsko6e0bb7+OS9Bz9ieFKzaC8Sf7tddmNoJ6G2wQ1LK OVxWlLw05egA5RmBtFO8APiXiZI25TyV8ysxE+LMQ473QTCXMtIhEnzhkHuY87fOP4kr UFSAjPHaSPYuopMegv613hOjLBj8wtvLC7xxi+2gd6uGAdm43lmqs9puLhJg0G2VqsLN 1QDCQRULucAxlZ1Wf7ZesMufcndyvjwIcsLI1EB2KTSsNys3a+bYf/IMyWxxRUUqYQ2m jLHYZGWI3rvxb3w3Q2d8nLHB8MP3PFeP1T0FCiIeF6OsaIXE/skQEdG0PX4/vyoAQxRp UqWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vHHu3NzC4I8VKiUc3z+22fu1gPCGvjYgIzzKU/AhOx0=; b=FtfUOjg7MI49yQFFIUIwMEz3in+m+0A5qz04dWMJEgc2ZaXB+YgMaAzKR1FRZg7yhM IBEV6l5tte9j4mkkU5LBu7AXrgnLLPklxgj8xrcIU2ACia4rnkL6El+gSnPnZYjvskLQ 6+XcQBXs7LHQRrQnBs+I+PVJKkhKyR/vpi+HalPJg3xPXolpZhMEheXv4hFofYpEajni eLMOEyz0nGalujmiqhX73EvFHrktK4SBk+BbOq17PbF1kUFyRPifCjH/GfJkaZcfJoc9 esNvYluTxcoVSEGkjaqGtof5RIwUJy6uHB92bssAVeb/JDL3uv5guq0Z5ZmL+0q4Werw kzyQ== X-Gm-Message-State: APjAAAXfuQkGJ5awAXotDWd42wgf1Bfzt3rlwrC0NYxQPmiD33QYKTR8 WfXx/55jNH388c9f6ZiMI5fmECh/ X-Google-Smtp-Source: APXvYqyqovnWyyBfXfo9s5bZP2NiCSNTQPFIwpijlkBXZqnaRZ23BnCpOuJoqVgLDtJqaB77rrpnxg== X-Received: by 2002:adf:ec4e:: with SMTP id w14mr8229470wrn.53.1553624909469; Tue, 26 Mar 2019 11:28:29 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc4:dc00:8c1:5e0b:d735:c3dc? (p200300EA8BC4DC0008C15E0BD735C3DC.dip0.t-ipconnect.de. [2003:ea:8bc4:dc00:8c1:5e0b:d735:c3dc]) by smtp.googlemail.com with ESMTPSA id q2sm29064356wrd.46.2019.03.26.11.28.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 11:28:28 -0700 (PDT) Subject: Re: [PATCH net-next 1/2] ethtool: add PHY Fast Link Down support To: Andrew Lunn , Michal Kubecek Cc: Florian Fainelli , David Miller , "John W. Linville" , "netdev@vger.kernel.org" References: <506ae10e-5d93-f64e-a615-c320010a5529@gmail.com> <20190325174928.GF26076@unicorn.suse.cz> <20190326082438.GB31524@lunn.ch> From: Heiner Kallweit Message-ID: <96fe4e87-f51a-e3ce-ae72-a726b3db53be@gmail.com> Date: Tue, 26 Mar 2019 19:24:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190326082438.GB31524@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 26.03.2019 09:24, Andrew Lunn wrote: >>> +#define ETHTOOL_PHY_FAST_LINK_DOWN_ON 0 >>> +#define ETHTOOL_PHY_FAST_LINK_DOWN_OFF 0xff >>> + >>> enum phy_tunable_id { >>> ETHTOOL_PHY_ID_UNSPEC, >>> ETHTOOL_PHY_DOWNSHIFT, >>> + ETHTOOL_PHY_FAST_LINK_DOWN, >>> /* >>> * Add your fresh new phy tunable attribute above and remember to update >>> * phy_tunable_strings[] in net/core/ethtool.c >> >> It would be nice to have a short summary around here explaining how is >> the value interpreted. While it's obvious from the second patch, one >> shouldn't have to go into driver specific implementation to find out. >> >> I also wonder if the range 0-254 ms is sufficient. Would it be possible >> that there is some other hardware which would support e.g. 300 ms? > > The default, as defined by the 802.3 standard, is i think 750ms. > Clause 40. From what I've found this applies to 1000BaseT only. > The Marvel PHY also supports 50ms, 20ms and 0ms, if i remember > correctly. > 0, 10, 20, 40ms (at least for 88E1540 and 88E6390) > One problem we have here is discovery. How does the user find out the > values the driver supports. For a netlink socket API, extended errors > could be used to pass back a string indicating the supported > values. For the old ethtool, i think all we have is -EINVAL, which is > not very helpful. > > Andrew > . > Heiner