From: David Ahern <dsa@cumulusnetworks.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: udp failures traced to e858fae2b0b8
Date: Mon, 13 Jun 2016 13:56:05 -0600 [thread overview]
Message-ID: <973d7528-2ea7-47e3-cf19-208c24d85dec@cumulusnetworks.com> (raw)
In-Reply-To: <20160613184040.GC14048@rapoport-lnx>
On 6/13/16 12:40 PM, Mike Rapoport wrote:
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9af0a98..9f8be96 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -482,10 +482,6 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
> if (hdr->hdr.flags & VIRTIO_NET_HDR_F_DATA_VALID)
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> - skb->protocol = eth_type_trans(skb, dev);
> - pr_debug("Receiving skb proto 0x%04x len %i type %i\n",
> - ntohs(skb->protocol), skb->len, skb->pkt_type);
> -
> if (virtio_net_hdr_to_skb(skb, &hdr->hdr,
> virtio_is_little_endian(vi->vdev))) {
> net_warn_ratelimited("%s: bad gso: type: %u, size: %u\n",
> @@ -494,6 +490,10 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
> goto frame_err;
> }
>
> + skb->protocol = eth_type_trans(skb, dev);
> + pr_debug("Receiving skb proto 0x%04x len %i type %i\n",
> + ntohs(skb->protocol), skb->len, skb->pkt_type);
> +
> napi_gro_receive(&rq->napi, skb);
> return;
>
>
Fixes the problem.
prev parent reply other threads:[~2016-06-13 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 2:47 udp failures traced to e858fae2b0b8 David Ahern
2016-06-13 6:42 ` Mike Rapoport
2016-06-13 13:48 ` David Ahern
2016-06-13 18:40 ` Mike Rapoport
2016-06-13 19:56 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973d7528-2ea7-47e3-cf19-208c24d85dec@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox