Re: [PATCH 05/10 net-next v2] drivers: net: drop ipv6_stub usage and use direct function calls

[Edward Cree <ecree.xilinx@gmail.com>]

On 10/03/2026 15:34, Fernando Fernandez Mancera wrote:
> As IPv6 is built-in only, the ipv6_stub infrastructure is no longer
> necessary.
> 
> Convert all drivers currently utilizing ipv6_stub to make direct
> function calls. The fallback functions introduced previously will
> prevent linkage errors when CONFIG_IPV6 is disabled.
> 
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
...
> diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c
> index d168282f30bf..d8a5f9fd1007 100644
> --- a/drivers/net/ethernet/sfc/tc_counters.c
> +++ b/drivers/net/ethernet/sfc/tc_counters.c
> @@ -112,7 +112,7 @@ static void efx_tc_counter_work(struct work_struct *work)
>  					 encap->neigh->egdev);
>  		else
>  #if IS_ENABLED(CONFIG_IPV6)
> -			n = neigh_lookup(ipv6_stub->nd_tbl,
> +			n = neigh_lookup(ipv6_get_nd_tbl(),
>  					 &encap->neigh->dst_ip6,
>  					 encap->neigh->egdev);
>  #else
> diff --git a/drivers/net/ethernet/sfc/tc_encap_actions.c b/drivers/net/ethernet/sfc/tc_encap_actions.c
> index da35705cc5e1..63d8f794b869 100644
> --- a/drivers/net/ethernet/sfc/tc_encap_actions.c
> +++ b/drivers/net/ethernet/sfc/tc_encap_actions.c
> @@ -149,8 +149,7 @@ static int efx_bind_neigh(struct efx_nic *efx,
>  #if IS_ENABLED(CONFIG_IPV6)
>  			struct dst_entry *dst;
>  
> -			dst = ipv6_stub->ipv6_dst_lookup_flow(net, NULL, &flow6,
> -							      NULL);
> +			dst = ip6_dst_lookup_flow(net, NULL, &flow6, NULL);
>  			rc = PTR_ERR_OR_ZERO(dst);
>  			if (rc) {
>  				NL_SET_ERR_MSG_MOD(extack, "Failed to lookup route for IPv6 encap");
> @@ -531,7 +530,7 @@ static int efx_neigh_event(struct efx_nic *efx, struct neighbour *n)
>  	if (n->tbl == &arp_tbl) {
>  		keysize = sizeof(keys.dst_ip);
>  #if IS_ENABLED(CONFIG_IPV6)
> -	} else if (n->tbl == ipv6_stub->nd_tbl) {
> +	} else if (n->tbl == ipv6_get_nd_tbl()) {
>  		ipv6 = true;
>  		keysize = sizeof(keys.dst_ip6);
>  #endif

# for sfc:
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>