netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, roopa@nvidia.com, andy@greyhouse.net,
	vfalico@gmail.com, kuba@kernel.org, davem@davemloft.net,
	alexander.duyck@gmail.com, idosch@nvidia.com,
	Nikolay Aleksandrov <nikolay@nvidia.com>
Subject: Re: [PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning
Date: Wed, 10 Feb 2021 18:06:25 -0800	[thread overview]
Message-ID: <9753.1613009185@famine> (raw)
In-Reply-To: <20210210204333.729603-1-razor@blackwall.org>

Nikolay Aleksandrov <razor@blackwall.org> wrote:

>From: Nikolay Aleksandrov <nikolay@nvidia.com>
>
>Hi,
>We'd like to have proper 200G and 400G support with 3ad bond mode, so we
>need to add new definitions for them in order to have separate oper keys,
>aggregated bandwidth and proper operation (patches 01 and 02). In
>patch 03 Ido changes the code to use pr_err_once instead of
>pr_warn_once which would help future detection of unsupported speeds.
>
>v2: patch 03: use pr_err_once instead of WARN_ONCE
>
>Thanks,
> Nik
>
>Ido Schimmel (1):
>  bonding: 3ad: Print an error for unknown speeds
>
>Nikolay Aleksandrov (2):
>  bonding: 3ad: add support for 200G speed
>  bonding: 3ad: add support for 400G speed
>
> drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++----
> 1 file changed, 22 insertions(+), 4 deletions(-)

	Patches 1 and 2 could have been one patch, I suppose, but not
really a big deal.  I'm in agreement about pr_err_once instead of
WARN_ONCE.

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com

  parent reply	other threads:[~2021-02-11  2:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 20:43 [PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning Nikolay Aleksandrov
2021-02-10 20:43 ` [PATCH net-next v2 1/3] bonding: 3ad: add support for 200G speed Nikolay Aleksandrov
2021-02-10 20:43 ` [PATCH net-next v2 2/3] bonding: 3ad: add support for 400G speed Nikolay Aleksandrov
2021-02-10 20:43 ` [PATCH net-next v2 3/3] bonding: 3ad: Print an error for unknown speeds Nikolay Aleksandrov
2021-02-10 21:05 ` [PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning Alexander Duyck
2021-02-11  2:06 ` Jay Vosburgh [this message]
2021-02-11 10:25 ` Nicolas Dichtel
2021-02-11 22:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9753.1613009185@famine \
    --to=jay.vosburgh@canonical.com \
    --cc=alexander.duyck@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).