From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542A5C433DB for ; Thu, 11 Feb 2021 02:07:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1854564EC0 for ; Thu, 11 Feb 2021 02:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbhBKCHY (ORCPT ); Wed, 10 Feb 2021 21:07:24 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:35139 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhBKCHQ (ORCPT ); Wed, 10 Feb 2021 21:07:16 -0500 Received: from 1.general.jvosburgh.us.vpn ([10.172.68.206] helo=famine.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lA1ND-0000x3-UJ; Thu, 11 Feb 2021 02:06:28 +0000 Received: by famine.localdomain (Postfix, from userid 1000) id BA7DA5FEE7; Wed, 10 Feb 2021 18:06:25 -0800 (PST) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id B26759FAC3; Wed, 10 Feb 2021 18:06:25 -0800 (PST) From: Jay Vosburgh To: Nikolay Aleksandrov cc: netdev@vger.kernel.org, roopa@nvidia.com, andy@greyhouse.net, vfalico@gmail.com, kuba@kernel.org, davem@davemloft.net, alexander.duyck@gmail.com, idosch@nvidia.com, Nikolay Aleksandrov Subject: Re: [PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning In-reply-to: <20210210204333.729603-1-razor@blackwall.org> References: <20210210204333.729603-1-razor@blackwall.org> Comments: In-reply-to Nikolay Aleksandrov message dated "Wed, 10 Feb 2021 22:43:30 +0200." X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 27.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9752.1613009185.1@famine> Date: Wed, 10 Feb 2021 18:06:25 -0800 Message-ID: <9753.1613009185@famine> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Nikolay Aleksandrov wrote: >From: Nikolay Aleksandrov > >Hi, >We'd like to have proper 200G and 400G support with 3ad bond mode, so we >need to add new definitions for them in order to have separate oper keys, >aggregated bandwidth and proper operation (patches 01 and 02). In >patch 03 Ido changes the code to use pr_err_once instead of >pr_warn_once which would help future detection of unsupported speeds. > >v2: patch 03: use pr_err_once instead of WARN_ONCE > >Thanks, > Nik > >Ido Schimmel (1): > bonding: 3ad: Print an error for unknown speeds > >Nikolay Aleksandrov (2): > bonding: 3ad: add support for 200G speed > bonding: 3ad: add support for 400G speed > > drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) Patches 1 and 2 could have been one patch, I suppose, but not really a big deal. I'm in agreement about pr_err_once instead of WARN_ONCE. Acked-by: Jay Vosburgh -J --- -Jay Vosburgh, jay.vosburgh@canonical.com