public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Cc: pavan.chebbi@broadcom.com, mchan@broadcom.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	lszubowi@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] tg3: Add PowerEdge R740xd to AER quirk list
Date: Sun, 5 Apr 2026 01:03:08 +0200	[thread overview]
Message-ID: <975ec123-e3df-41d5-bb15-f3af8af2c340@lunn.ch> (raw)
In-Reply-To: <20260404225023.1254-1-rayfraytech@gmail.com>

On Sun, Apr 05, 2026 at 12:50:23AM +0200, Oskar Ray-Frayssinet wrote:
> The PowerEdge R740xd is a variant of the R740 that also triggers
> a fatal PCIe AER event during system reboot. Add it to the DMI
> list to apply the same workaround.
> 
> Fixes: e0efe83ed325 ("tg3: Disable tg3 PCIe AER on system reboot")
> 
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
> v2: Also add "R740XD vSAN Ready Node" DMI name as reported in
>     bugzilla #221279 by Thomas Berger
> v1: Add "PowerEdge R740xd" DMI name

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

says: 

 * don’t repost your patches within one 24h period

> @@ -18216,6 +18216,18 @@ static const struct dmi_system_id tg3_restart_aer_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740xd"),
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "R740XD vSAN Ready Node"),
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

When you look at tg3_restart_aer_quirk_table[] they are all Dell. Are
there any Dell systems which actually work? Would it make sense to
mark all Dell systems as broken and enable the quirk? Then there is no
need to play whack-a-mole.

     Andrew

  reply	other threads:[~2026-04-04 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04 22:50 [PATCH net v2] tg3: Add PowerEdge R740xd to AER quirk list Oskar Ray-Frayssinet
2026-04-04 23:03 ` Andrew Lunn [this message]
2026-04-05 10:56   ` Oskar Ray-Frayssinet
2026-04-05 23:49     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=975ec123-e3df-41d5-bb15-f3af8af2c340@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lszubowi@redhat.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=rayfraytech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox