From: Paolo Abeni <pabeni@redhat.com>
To: Yuyang Huang <sigefriedhyy@gmail.com>
Cc: netdev-bot+sashiko@kernel.org, ajay.kathat@microchip.com,
aleksandr.loktionov@intel.com, andrew+netdev@lunn.ch,
claudiu.beznea@tuxon.dev, davem@davemloft.net,
dsahern@kernel.org, donald.hunter@gmail.com, edumazet@google.com,
idosch@nvidia.com, jacob.e.keller@intel.com, kuba@kernel.org,
johannes@sipsolutions.net, kees@kernel.org,
kory.maincent@bootlin.com, kuniyu@google.com,
nicolas.dichtel@6wind.com, nickgarlis@gmail.com,
sd@queasysnail.net, shuah@kernel.org, horms@kernel.org,
sdf.kernel@gmail.com, vadim.fedorenko@linux.dev,
willemb@google.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v11 3/6] net: add a generation counter for dev->mc changes
Date: Tue, 20 Oct 2026 09:11:45 +0200 [thread overview]
Message-ID: <976d815d-a9ec-4fa0-9b16-8e55695706c2@redhat.com> (raw)
In-Reply-To: <CA+7S2v+rWYvz9xKPEeM6=3HPz3o7TbX2uRfRKk95f9Y60HnEiA@mail.gmail.com>
On 10/19/26 13:35, Yuyang Huang wrote:
> On Mon, Oct 19, 2026 at 8:19 PM Paolo Abeni <pabeni@redhat.com> wrote:
>>
>> I agree this is not a blocker, but I think it would be nice if you could
>> follow-up on this one.
>>
>> The solution proposed by the LLM LGTM.
>>
>> Same here.
>>
>> Also, still speaking of possible follow-up, I think it would be nice if
>> you could change the addr list lifecycle to RCU (no idea of how much
>> complex would be that).
>>
>
> Thanks for the review. Since we're already at v12 I'd rather not respin
> just for these, but I agree both are worth fixing, so I'll handle them as
> follow ups.
>
> The first one is a simple fix, so if v13 ends up being needed
> for other reasons I'll fold it in there, otherwise I'll send it as a
> separate patch.
>
> The RCU conversion needs more thought and will probably
> cause quite a bit of churn, so I'll try it if there's a v13, and if it
> gets too messy. I'll post it separately later.
To clarify: every I mentioned in my previous email was about possible
follow-ups - not to be included here.
My understanding is that there is sort of a pending/implicit question
from Jakub on v9: why are you doing this? is does it solve some
specific scaling problem or is 'nl is nicer" thing?
/P
next prev parent reply other threads:[~2026-10-20 7:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 1:17 [PATCH net-next v11 0/6] rtnetlink: dump link-layer multicast addresses Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 1/6] netlink: specs: rt-addr: fix the type of target-netnsid Yuyang Huang
2026-10-13 2:04 ` netdev-bot+sashiko
2026-10-13 10:21 ` Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 2/6] net: change netdev_hw_addr_list count through helpers Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 3/6] net: add a generation counter for dev->mc changes Yuyang Huang
2026-10-13 2:04 ` netdev-bot+sashiko
2026-10-13 10:25 ` Yuyang Huang
2026-10-19 11:19 ` Paolo Abeni
2026-10-19 11:35 ` Yuyang Huang
2026-10-20 7:11 ` Paolo Abeni [this message]
2026-10-20 10:22 ` Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 4/6] net: add AF_PACKET multicast dumps Yuyang Huang
2026-10-13 2:05 ` netdev-bot+sashiko
2026-10-13 10:27 ` Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 5/6] netlink: specs: rt-addr: document " Yuyang Huang
2026-10-12 1:17 ` [PATCH net-next v11 6/6] selftests: net: test " Yuyang Huang
2026-10-14 10:46 ` Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=976d815d-a9ec-4fa0-9b16-8e55695706c2@redhat.com \
--to=pabeni@redhat.com \
--cc=ajay.kathat@microchip.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickgarlis@gmail.com \
--cc=nicolas.dichtel@6wind.com \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
--cc=sigefriedhyy@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox