From: "Austin, Alex (DCCG)" <alex.austin@amd.com>
To: 陈爱兵 <chenaibing@cmss.chinamobile.com>, netdev <netdev@vger.kernel.org>
Cc: linux-net-drivers <linux-net-drivers@amd.com>,
"ecree.xilinx" <ecree.xilinx@gmail.com>,
"habetsm.xilinx" <habetsm.xilinx@gmail.com>
Subject: Re: [PATCH net-next] sfc: add missing prototypes for ef10 helper functions
Date: Thu, 12 Nov 2026 10:56:42 +0000 [thread overview]
Message-ID: <9776328c-19a2-4025-b8b3-c008db019448@amd.com> (raw)
In-Reply-To: <2aff6af5293d4b3-00050.Richmail.00005386047582601673@cmss.chinamobile.com>
On 12/11/2026 03:44, 陈爱兵 wrote:
>
> From: chenaibing <chenaibing@cmss.chinamobile.com>
>
> Fix the following W=1 warnings when building with -Wmissing-prototypes:
>
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_vadaptor_query' [-Wmissing-prototypes]
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_vadaptor_alloc' [-Wmissing-prototypes]
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_vadaptor_free' [-Wmissing-prototypes]
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_vport_add_mac' [-Wmissing-prototypes]
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_vport_del_mac' [-Wmissing-prototypes]
> drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
> 'efx_ef10_tx_tso_desc' [-Wmissing-prototypes]
>
> These non-static functions are defined in ef10.c and called from
> ef10_sriov.c, but have no declaration in any shared header.
> Add the missing prototypes to efx.h.
>
> Signed-off-by: chenaibing <chenaibing@cmss.chinamobile.com>
> ---
> drivers/net/ethernet/sfc/efx.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/efx.h b/drivers/net/ethernet/sfc/efx.h
> index 1234567890ab..abcdef123456 100644
> --- a/drivers/net/ethernet/sfc/efx.h
> +++ b/drivers/net/ethernet/sfc/efx.h
> @@ -209,6 +209,18 @@ int efx_xdp_tx_buffers(struct efx_nic *efx, int n, struct xdp_frame **xdpfs,
> bool flush);
>
> +/* ef10.c: exported helpers also used by ef10_sriov.c */
> +int efx_ef10_vadaptor_query(struct efx_nic *efx, unsigned int port_id,
> + u32 *port_flags, u32 *vadaptor_flags,
> + unsigned int *vlan_tags);
> +int efx_ef10_vadaptor_alloc(struct efx_nic *efx, unsigned int port_id);
> +int efx_ef10_vadaptor_free(struct efx_nic *efx, unsigned int port_id);
> +int efx_ef10_vport_add_mac(struct efx_nic *efx,
> + unsigned int port_id, const u8 *mac);
> +int efx_ef10_vport_del_mac(struct efx_nic *efx,
> + unsigned int port_id, const u8 *mac);
> +int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb,
> + bool *data_mapped);
> +
> #endif /* EFX_EFX_H */
> --
> 2.39.0
These declarations already exist in ef10_sriov.h and nic.h. Does this
patch apply to net-next?
next parent reply other threads:[~2026-11-12 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2aff6af5293d4b3-00050.Richmail.00005386047582601673@cmss.chinamobile.com>
2026-11-12 10:56 ` Austin, Alex (DCCG) [this message]
2026-11-12 6:55 [PATCH net-next] sfc: add missing prototypes for ef10 helper functions Chen Aibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9776328c-19a2-4025-b8b3-c008db019448@amd.com \
--to=alex.austin@amd.com \
--cc=chenaibing@cmss.chinamobile.com \
--cc=ecree.xilinx@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox