From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED96E346A18 for ; Wed, 7 Oct 2026 06:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791352873; cv=none; b=W2X+81rV/pBIl9yyoZnGrAs9txrRzELJkyczFn1VxDfXiA2wZU4Y6vuC5lMEkrjZ2Uep8dAwlEn4kiFPUQngSNiHweCBd+YbVGH+npE5C16OpGfF36Jm3fIpTIp8O6YEBLj/BGas98dHehl/XeemmOJRRUoFjP33K3DOQI2jNZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791352873; c=relaxed/simple; bh=44gmmM9oEH5/TVerkgLJ1mXkmCq7t1aLZaAtaClW8/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gWCu6cWrpEkIh9NkF5ehrVkLn5Kbi7nwK7iDCH4JO1cAqN+9XDLrNRPKpMF44J8Jlc1SvaSN53+gcrpn5X2aS+393/vO+O43D/RS6gpi0qQg/6TGI+6To8exoKGv+0d4d8DFbzdsnViaMsRfA2trRWZJcYJJxH/+3j5OlGnc4Ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DDSCJQVt; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DDSCJQVt" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-53391022dc0so13877051cf.2 for ; Tue, 06 Oct 2026 23:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791352871; x=1791957671; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Nfq/HGRukfZcQBpC30XOdveBT0IdwDENsOU1DxIVVJg=; b=DDSCJQVthpfjYG7ohZTHgwatt6RJFFXnzT9IbzUVqRo35PU8MwwLDGmSnwE/fZLu4A wsmNkpHIw13cwsFMBdphj0BIJaxeevcB/zvRHQsqsHOjkYFdrOIF8HszH6rra05o2cp/ Er0fx3n+PiMYW1SjCAdWuqb0Vyol6BemtAMc6ia656tXKXuZchvCJgLYYYjHH4lnRGeJ yTmK3HJSQA2WuPFeyJ85MNGDaZt4FGKbLqS+/ghBEBj08EVfJk27N7mC0PTwN32iyR/i itgkxdPtkMP4v3yihLwAxchVLb5lRc7fKtIoXONkkPDwxWe+IHNoNb1GB3MhhC/PLGAS Ds3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791352871; x=1791957671; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nfq/HGRukfZcQBpC30XOdveBT0IdwDENsOU1DxIVVJg=; b=F8oRzzKKUSZybRa9tqnW4eLAO7M+ejqZOAhtVri7nGO0CII0XN8ZsZfcwd+/xe2Apq 9qG1a7I3WUJzaI5EWnTgkNHNfVmBqcEBOlVTWzNZwY0xTNIBrNGzo/jGYnWg2YxkLvH7 qIj7Yz8ue3Hl4xqOhK1X9dpTQQL80T4EFsC0qdWJQjA3ktycvk3NHa+DlEwsPnC/pg8D korSzUvgAsZ/UofSh+XArrW6BXwLfpvJfSn5+2SimxSt77UJgXXQL/MT7bNqIJeI+H4E wbO1mxTqcue02Ps8FOVZhxO7F5viMymykh4bEq59nyueXQhMwefXEj4A6f6J6SF32n9e vdNg== X-Forwarded-Encrypted: i=1; AKwUvBxZCkcv1uovcowsDfjWuhHvoOyN5HPXkLgvLHKnE1HIuBJG9bnE8CMaIsW3qaMmryVOdQS36aQ=@vger.kernel.org X-Gm-Message-State: AFuF++l0+97grTeaCHf0hf+dlIMM+FEeNWTh7YsagPj0rnq4Twj7oPNx g7MPtm8Dd0CUVlgWvEEk3lI+1TZID1ENY8toVFU48vPNm53rnpOjPurKB8tSCw== X-Gm-Gg: AYBFou29qsyi5/kacvUDu4O7dzGG1LCf8aMu+kXTgj48QE88XiapYtenGXp50tITSzu 5kCOafsf6ldXNap8tfh8BlD8VJZz3AME0IxFX04jlhnd9oau3K0LrsiovKdoEp3YrF+6yeulh12 /sTs17aj5SNb+CZP8nWbqSyd2MgzojK8buQr/BllTc4gMD2hXZhp9a5wOCZrPJ+xEP9xgGSu+Gb cA+CuyKz6uSBuPjWeXwftSdue3/j83ksSDouABJBeD3LcCczwMGsn7YG5+PgZ6aQzT5NQYDVuYH 1HftKiwPYub+yyhdwWhKFpbx87OW4itgBPRB/GSJAuUeYoxQJpOjFyIIu9MU60d/Uj0A7RaXcFE 9BozwYrpWwYAwY8rXJFVSTrVO2VW8jRl9NMZKTrE/5aja4pI7AnlmLOjKEkhVsFxN4q9K8S6ive KXRjkJUyLPddUJQ8WlHz8WxAqhZlR8PLDs4u8bT6Rv/RxNI0R3QseVjY86as8cVLkmMoEPVDyH1 Av1c48X5dAivQQcuOu5zgGUTFeKSR68tkRLKJpaoYldAp47nQkYbVvUl6lo8Stmm7V5F98uUomr PT1VSpzVDQWp+GDGmxRC56xOquTK+AY= X-Received: by 2002:a05:622a:4d44:b0:535:1241:965f with SMTP id d75a77b69052e-535756ac39bmr20079451cf.40.1791352870621; Tue, 06 Oct 2026 23:01:10 -0700 (PDT) Received: from ?IPV6:2003:ea:8f23:8600:d56a:6e66:bc:e98e? (p200300ea8f238600d56a6e6600bce98e.dip0.t-ipconnect.de. [2003:ea:8f23:8600:d56a:6e66:bc:e98e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5357217327asm12835161cf.22.2026.10.06.23.01.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2026 23:01:10 -0700 (PDT) Message-ID: <9777c133-0d46-4efe-88d7-8a519f38b0f8@gmail.com> Date: Wed, 7 Oct 2026 08:01:06 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v1 1/1] r8169: disable EEE on RTL8168h/8111h To: Dennis Piecha , Oleksij Rempel , "patchwork-bot+netdevbpf@kernel.org" Cc: "andrew@lunn.ch" , "nic_swsd@realtek.com" , "davem@davemloft.net" , "edumazet@kernel.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "stable@vger.kernel.org" , "kernel@pengutronix.de" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" References: <20260925071040.2137178-1-o.rempel@pengutronix.de> <179081461327.2189941.5041238879527277665.git-patchwork-notify@kernel.org> <503211732.1051249.1791285565321@mail.yahoo.com> Content-Language: en-US From: Heiner Kallweit In-Reply-To: <503211732.1051249.1791285565321@mail.yahoo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06.10.2026 13:19, Dennis Piecha wrote: > Hi Oleksij, > > I tested this on the affected machine with a Home Assistant OS test > build that includes the patch (kernel 6.18.54-haos). > > Hardware: Intel NUC11ATKPE, RTL8168h/8111h (XID 541), FRITZ!Box 6690 > as link partner, no VLANs. > > With the patch the NIC reports EEE as not supported and the RX stall > is gone: more than 4 hours without a single drop, everything on > defaults, no workaround. Before, on 6.18.52 without the patch, it > stalled every 7-20 minutes. > I'm pretty sure that EEE was active for this chip version in earlier times. Are you sure it's not an issue on the link partner side? Did you test with a switch between your system and the FRITZ!Box? > Since 6.18.y stable is affected (that's where the PHY EEE fix was > backported), it would be great to see this there too. > > Tested-by: Dennis Piecha > > Thanks for the fix! > Dennis > > > > > > > Am Donnerstag, 1. Oktober 2026 um 02:30:16 MESZ hat Folgendes geschrieben: > > > > > > Hello: > > This patch was applied to netdev/net.git (main) > by Jakub Kicinski : > > On Fri, 25 Sep 2026 09:10:40 +0200 you wrote: >> Force EEE off on the RTL8168h/8111h (RTL_GIGA_MAC_VER_46) at PHY connect >> with phy_disable_eee(). >> >> Commit 202fef9bbbf5 ("net: phy: realtek: fix EEE advertisement write on >> the internal PHY MMD path") made EEE actually advertise on the generic >> Realtek PHY; the write had been a no-op before. On the RTL8168h that >> un-masks a latent defect: once EEE negotiates, RX silently stalls after >> ~7-20 minutes. The carrier stays up, no counter or dmesg moves, and only >> "ip link set down/up" recovers it; disabling EEE keeps the link stable. >> >> [...] > > Here is the summary with links: > - [net,v1,1/1] r8169: disable EEE on RTL8168h/8111h > https://git.kernel.org/netdev/net/c/3cdeaef1754a > > You are awesome, thank you!