From: "Laurent Chavey" <chavey@google.com>
To: netdev@vger.kernel.org
Subject: bond_3ad.c: why does bond_3ad_set_carrier() check if the mac partnet mac is set.
Date: Thu, 31 May 2007 18:46:42 -0700 [thread overview]
Message-ID: <97949e3e0705311846x65ba3eacjb11e68ba38e1ed38@mail.gmail.com> (raw)
if a host configured with 802.3ad bond mode is connected to a switch
that does not support 802.3ad, then an aggregator is selected as the
active aggregator (first link that has carrier in the slave list).
This is perfectly fine, since it lets at least one of the link become active.
(this was the behavior prior to 2.6.18)
In 2.6.18 and above, a new check for the partner mac address was added
before an aggregator's carrier is set on. If a host is configured as
previously
described, then no links will become active.
is that the intended behavior ?
-----
in the scenario described here, the partner mac address is always set to NULL.
so the statement is always false.
if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) {
if (!netif_carrier_ok(bond->dev)) {
netif_carrier_on(bond->dev);
return 1;
}
return 0;
}
----
reply other threads:[~2007-06-01 1:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97949e3e0705311846x65ba3eacjb11e68ba38e1ed38@mail.gmail.com \
--to=chavey@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).