From: "Laurent Chavey" <chavey@google.com>
To: netdev@vger.kernel.org
Subject: [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance
Date: Fri, 1 Jun 2007 09:33:42 -0700 [thread overview]
Message-ID: <97949e3e0706010933h6921ca72p9858daa229bcfce6@mail.gmail.com> (raw)
%diff -ru linux-2.6.21.3/drivers/net/bonding/bond_3ad.c
linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c
--- linux-2.6.21.3/drivers/net/bonding/bond_3ad.c 2007-05-24
14:22:47.000000000 -0700
+++ linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c 2007-06-01
09:28:07.000000000 -0700
@@ -2312,10 +2312,7 @@
*/
int bond_3ad_set_carrier(struct bonding *bond)
{
- struct aggregator *agg;
-
- agg = __get_active_agg(&(SLAVE_AD_INFO(bond->first_slave).aggregator));
- if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) {
+ if (__get_active_agg(&(SLAVE_AD_INFO(bond->first_slave).aggregator))) {
if (!netif_carrier_ok(bond->dev)) {
netif_carrier_on(bond->dev);
return 1;
On 5/31/07, Laurent Chavey <chavey@google.com> wrote:
> if a host configured with 802.3ad bond mode is connected to a switch
> that does not support 802.3ad, then an aggregator is selected as the
> active aggregator (first link that has carrier in the slave list).
> This is perfectly fine, since it lets at least one of the link become active.
> (this was the behavior prior to 2.6.18)
>
> In 2.6.18 and above, a new check for the partner mac address was added
> before an aggregator's carrier is set on. If a host is configured as
> previously
> described, then no links will become active.
>
> is that the intended behavior ?
>
>
> -----
> in the scenario described here, the partner mac address is always set to NULL.
> so the statement is always false.
>
> if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) {
> if (!netif_carrier_ok(bond->dev)) {
> netif_carrier_on(bond->dev);
> return 1;
> }
> return 0;
> }
> ----
>
next reply other threads:[~2007-06-01 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 16:33 Laurent Chavey [this message]
2007-06-01 17:30 ` [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance Jay Vosburgh
2007-06-01 17:56 ` Laurent Chavey
2007-06-01 19:15 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97949e3e0706010933h6921ca72p9858daa229bcfce6@mail.gmail.com \
--to=chavey@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).