From: Ping-Ke Shih <pkshih@realtek.com>
To: "martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"neojou@gmail.com" <neojou@gmail.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"macroalpha82@gmail.com" <macroalpha82@gmail.com>,
"jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
"nitin.gupta981@gmail.com" <nitin.gupta981@gmail.com>
Subject: Re: [RFC PATCH v1 13/19] rtw88: mac: Add support for SDIO specifics in the power on sequence
Date: Thu, 29 Dec 2022 11:24:20 +0000 [thread overview]
Message-ID: <97a2efacecd6d6bb7add6e227a68f7d9e1ed9d0b.camel@realtek.com> (raw)
In-Reply-To: <CAFBinCAzmgwRAzAbXM17nmPw0bo9Mzx6gQQQrR3tPDb+n2jDHA@mail.gmail.com>
On Thu, 2022-12-29 at 11:49 +0100, Martin Blumenstingl wrote:
> Hi Ping-Ke,
>
> On Thu, Dec 29, 2022 at 2:15 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> [...]
> > > + if (rtw_sdio_is_sdio30_supported(rtwdev))
> > > + rtw_write8_set(rtwdev, REG_HCI_OPT_CTRL + 2, BIT(2));
> >
> > BIT_USB_LPM_ACT_EN BIT(10) // reg_addr +2, so bit >> 8
> The ones above are clear to me, thank you.
> But for this one I have a question: don't we need BIT(18) for this one
> and then bit >> 16?
> reg_addr + 0: bits 0..7
> reg_addr + 1: bits 8..15
> reg_addr + 2: bits 16..23
>
>
Sorry, my mistakes.
It should be "BIT_SDIO_PAD_E5 BIT(18)" and >> 16.
--
Ping-Ke
next prev parent reply other threads:[~2022-12-29 11:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 23:30 [RFC PATCH v1 00/19] rtw88: Add SDIO support Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 01/19] rtw88: mac: Use existing interface mask macros in rtw_pwr_seq_parser() Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 02/19] rtw88: pci: Change type of rtw_hw_queue_mapping() and ac_to_hwq to enum Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 03/19] rtw88: pci: Change queue datatype from u8 to enum rtw_tx_queue_type Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 04/19] rtw88: Move enum rtw_tx_queue_type mapping code to tx.{c,h} Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 05/19] mmc: sdio: add Realtek SDIO vendor ID and various wifi device IDs Martin Blumenstingl
2023-01-03 11:41 ` Ulf Hansson
2022-12-27 23:30 ` [RFC PATCH v1 06/19] rtw88: rtw8821c: Add support for parsing the RTL8821CS (SDIO) efuse Martin Blumenstingl
2022-12-28 6:21 ` Ping-Ke Shih
2022-12-27 23:30 ` [RFC PATCH v1 07/19] rtw88: rtw8822b: Add support for parsing the RTL8822BS " Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 08/19] rtw88: rtw8822c: Add support for parsing the RTL8822CS " Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 09/19] rtw88: hci: Add an optional power_switch() callback to rtw_hci_ops Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 10/19] rtw88: mac: Add support for the SDIO HCI in rtw_pwr_seq_parser() Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 11/19] rtw88: mac: Add support for the SDIO HCI in the TX/page table setup Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 12/19] rtw88: sdio: Add HCI implementation for SDIO based chipsets Martin Blumenstingl
2022-12-28 9:39 ` Ping-Ke Shih
2022-12-28 11:59 ` Martin Blumenstingl
2022-12-29 0:50 ` Ping-Ke Shih
2023-01-03 11:42 ` Ulf Hansson
2022-12-27 23:30 ` [RFC PATCH v1 13/19] rtw88: mac: Add support for SDIO specifics in the power on sequence Martin Blumenstingl
2022-12-29 1:14 ` Ping-Ke Shih
2022-12-29 10:49 ` Martin Blumenstingl
2022-12-29 11:24 ` Ping-Ke Shih [this message]
2022-12-27 23:30 ` [RFC PATCH v1 14/19] rtw88: main: Add the rpwm_addr and cpwm_addr for SDIO based chipsets Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 15/19] rtw88: main: Reserve 8 bytes of extra TX headroom for SDIO based cards Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 16/19] rtw88: ps: Increase LEAVE_LPS_TRY_CNT for SDIO based chipsets Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 17/19] rtw88: Add support for the SDIO based RTL8822BS chipset Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset Martin Blumenstingl
2022-12-29 1:40 ` Ping-Ke Shih
2022-12-27 23:30 ` [RFC PATCH v1 19/19] rtw88: Add support for the SDIO based RTL8821CS chipset Martin Blumenstingl
2023-01-03 23:01 ` Chris Morgan
2023-01-04 15:40 ` Martin Blumenstingl
2023-01-04 17:05 ` Chris Morgan
2023-01-04 17:23 ` Martin Blumenstingl
2023-01-04 22:45 ` Chris Morgan
2023-01-04 19:59 ` Bitterblue Smith
2023-01-04 20:06 ` Felix Schwarz
2023-01-04 20:14 ` Larry Finger
2023-01-07 14:53 ` Bitterblue Smith
2023-01-05 8:01 ` Sascha Hauer
2023-01-05 15:38 ` Bitterblue Smith
2022-12-29 4:19 ` [RFC PATCH v1 00/19] rtw88: Add SDIO support Ping-Ke Shih
2022-12-29 23:18 ` Martin Blumenstingl
2022-12-30 0:06 ` Ping-Ke Shih
2023-01-16 16:01 ` Kalle Valo
2023-01-17 17:21 ` Jakub Kicinski
2023-01-17 18:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a2efacecd6d6bb7add6e227a68f7d9e1ed9d0b.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=jernej.skrabec@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neojou@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nitin.gupta981@gmail.com \
--cc=tony0620emma@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).