From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [regression] r8169 without realtek_phy Date: Fri, 17 Aug 2018 10:39:17 -0700 Message-ID: <97ad7aae-34f5-a1bc-7131-81eaeea4f4dd@gmail.com> References: <9fde169119652baae87d6a0f40e0ccd70e428ea8.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: =?UTF-8?B?Sm91bmkgTWV0dMOkbMOk?= , netdev@vger.kernel.org, hkallweit1@gmail.com Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:43526 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727365AbeHQUnm (ORCPT ); Fri, 17 Aug 2018 16:43:42 -0400 Received: by mail-qk0-f196.google.com with SMTP id z74-v6so6755306qkb.10 for ; Fri, 17 Aug 2018 10:39:26 -0700 (PDT) In-Reply-To: <9fde169119652baae87d6a0f40e0ccd70e428ea8.camel@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: +Heiner, On 08/17/2018 01:33 AM, Jouni Mettälä wrote: > There is network regression for me. 4.18 was good. 4.18+ is bad. There > was some phy changes in r8169 driver. Fortunately adding > CONFIG_REALTEK_PHY=m to kernel config fixed the regression. > > Should r8169 depend on realtek_phy? Does that breaks something else? That would be reasonable given that there is now a hard dependency on the r8169 driver having the right PHY driver, since the Generic PHY driver likely wont' do all the workarounds. Heiner, what do you think? > > Network doesn't work with Generic PHY (output of dmesg) > Generic PHY r8169-300:00: attached PHY driver [Generic PHY] > (mii_bus:phy_addr=r8169-300:00, irq=IGNORE) > > When realtek_phy is compiled, r8169 automatically uses it. > RTL8211B Gigabit Ethernet r8169-300:00: attached PHY driver [RTL8211B > Gigabit Ethernet] (mii_bus:phy_addr=r8169-300:00, irq=IGNORE) > > Here is Ethernet controller's lspci for reference: > 03:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. > RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168] > (rev 01) > Subsystem: ABIT Computer Corp. RTL8111/8168/8411 PCI Express > Gigabit Ethernet Controller [147b:1078] > Flags: bus master, fast devsel, latency 0, IRQ 27 > I/O ports at ce00 [size=256] > Memory at fddff000 (64-bit, non-prefetchable) [size=4K] > [virtual] Expansion ROM at fdd00000 [disabled] [size=64K] > Capabilities: [40] Power Management version 2 > Capabilities: [48] Vital Product Data > Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+ > Capabilities: [60] Express Endpoint, MSI 00 > Capabilities: [84] Vendor Specific Information: Len=4c > Capabilities: [100] Advanced Error Reporting > Capabilities: [12c] Virtual Channel > Capabilities: [148] Device Serial Number 28-00-00-00-00-00-00- > 00 > Capabilities: [154] Power Budgeting > Kernel driver in use: r8169 > Kernel modules: r8169 > -- Florian