From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1429A3F7879;
	Thu, 14 May 2026 13:58:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778767111; cv=none; b=TVvCAsFQAl3dNyZP6NneQPczom0EwqWOSO8P/wUDfawJiACd6O4sx8K6z2+udzFLhzQ/DMiVs9YD0QWbTWU+ap5IqcXrak/UUqkYF7qQduYJaRjTLv7lq7L4VPBa2vW4nm7jmpplWm8YtiZA4GfyKtNYMDxMvlJicVcu56M4fgk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778767111; c=relaxed/simple;
	bh=IpQRPS/QXNA05i/KLfp7zVB20D0Xi21jaIzWK6d3jUA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=SFYHwNHoGEudBW8P9EZZkulLmyTolWBFEndI7SLEP5v0/tMBclB10uKK83fhkb9N2xpahsnBbzQet7xlqmOwdLGwJHfkc4Zq6KT2vDcNJy5TKbtXBtx7yYTVqYlKpGr0g163BfRPJMb2/eWXZVG+cYFKMRG6xVSYqNfV8Ab5o3g=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=sRBXktya; arc=none smtp.client-ip=156.67.10.101
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="sRBXktya"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
	s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
	References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
	Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
	Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
	bh=tb7Ilqy5tYBc75bWfnRGdJnWN4klCwOLklpvTsD0qi4=; b=sRBXktya5aahAe8OkztHKBvM1v
	p9EqX3Qp0xudkZHIuXxvDWIxD9yskxkoMf+7YXOsA8oSWKeewtonBhPZ3WqFQlDcZNJ4CBtnDuBi6
	Zb984y+QCChWon9LY/YFv4ncc/Mit1zHXXfCpBXxyQV8kOdh/RMFM69RzcYZYvhWeu2E=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
	(envelope-from <andrew@lunn.ch>)
	id 1wNWZx-002ueZ-BG; Thu, 14 May 2026 15:58:21 +0200
Date: Thu, 14 May 2026 15:58:21 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Herve Codina <herve.codina@bootlin.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	=?iso-8859-1?Q?K=F6ry?= Maincent <kory.maincent@bootlin.com>,
	Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	=?iso-8859-1?Q?Nicol=F2?= Veronese <nicveronese@gmail.com>,
	Simon Horman <horms@kernel.org>, mwojtas@chromium.org,
	Romain Gantois <romain.gantois@bootlin.com>,
	Daniel Golle <daniel@makrotopia.org>,
	Dimitri Fedrau <dimitri.fedrau@liebherr.com>,
	Frank Wunderlich <frank.wunderlich@linux.dev>
Subject: Re: [PATCH net-next v10 6/9] net: phy: phy_port: Store information
 about a MII port's vacant state
Message-ID: <97cd33a0-ee74-4f64-b11a-bb5b88bce79a@lunn.ch>
References: <20260513130521.1064094-1-maxime.chevallier@bootlin.com>
 <20260513130521.1064094-7-maxime.chevallier@bootlin.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260513130521.1064094-7-maxime.chevallier@bootlin.com>

> We have information about what MII they can handle, however we don't
> store anything about whether they are currently connected to an SFP
> module or not. As phy_port aims at listing the front-facing ports, let's
> store an "vacant" bit to know whether or not a MII port is currently
> vacant (i.e. there's no module in the SFP cage), or not (i.e.
> there's an SFP module).

vacant == False actually means a bit more than there is a module in
the cage. It also means that, so far, we have not had any errors
trying to use the module. If there is an error, we might have a module
physically in the cage, but vacant == True. 

We should be careful with the wording, both in the commit message, and
here:

> + * @vacant: For MII ports, indicates whether or not the port has a connection to
> + *	    another device (e.g. for SFP ports, indicates the absence or presence
> + *	    of an SFP module)
>   */

    Andrew