From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Allen Subject: [PATCH net v2 0/3] ibmvnic: Reset behavior fixes Date: Thu, 18 Jan 2018 16:25:39 -0600 Message-ID: <97de0d55-5b81-40f9-c3b8-0d28e4d80539@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Falcon , Nathan Fontenot To: netdev@vger.kernel.org Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57458 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753189AbeARWZo (ORCPT ); Thu, 18 Jan 2018 17:25:44 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0IMPA8Z031083 for ; Thu, 18 Jan 2018 17:25:44 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fk1btfbjh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 18 Jan 2018 17:25:43 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jan 2018 17:25:43 -0500 Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: This patchset fixes a number of issues related to ibmvnic reset uncovered from testing new Power9 machines with Everglades adapters and the new functionality to change mtu and other parameters in the driver. Changes since v1: -In patch 1/3, added the line to free the long term buffers before allocating a new one. This change inadvertently uncovered the problem that the number of queues can change after a failover as well. To fix this, we check whether or not the number of queues has changed in do_reset and if they have, we do a full release and init of the queues. -In patch 1/3, added variables to the adapter struct to track how many rx/tx pools have actually been allocated and modify the release pools routines to use these values rather than the possibly incorrect req_rx/tx_queues values. John Allen (3): ibmvnic: Modify buffer size and number of queues on failover ibmvnic: Revert to previous mtu when unsupported value requested ibmvnic: Allocate and request vpd in init_resources drivers/net/ethernet/ibm/ibmvnic.c | 73 ++++++++++++++++++++++++++++++-------- drivers/net/ethernet/ibm/ibmvnic.h | 2 ++ 2 files changed, 60 insertions(+), 15 deletions(-) -- 2.9.5