public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	<jacob.e.keller@intel.com>, <xudu@redhat.com>
Cc: <netdev@vger.kernel.org>, <anthony.l.nguyen@intel.com>,
	<magnus.karlsson@intel.com>, <mschmidt@redhat.com>,
	<jmaxwell@redhat.com>, <poros@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic
Date: Thu, 16 Jan 2025 17:19:43 +0100	[thread overview]
Message-ID: <97dffc47-3363-4a0d-983a-5620fa5ad745@intel.com> (raw)
In-Reply-To: <20250116153908.515848-1-maciej.fijalkowski@intel.com>

On 1/16/25 16:39, Maciej Fijalkowski wrote:
> Hello in 2025,
> 
> this patchset fixes a pretty nasty issue that was reported by RedHat
> folks which occured after ~30 minutes (this value varied, just trying
> here to state that it was not observed immediately but rather after a
> considerable longer amount of time) when ice driver was tortured with
> jumbo frames via mix of iperf traffic executed simultaneously with
> wrk/nginx on client/server sides (HTTP and TCP workloads basically).
> 


> 
> Special thanks to Xu Du for providing reproducer and Jacob Keller for
> initial extensive analysis.
> 
> Thanks,
> Maciej

Thank you all for this piece of gold, including description.

> 
> Maciej Fijalkowski (3):
>    ice: put Rx buffers after being done with current frame
>    ice: gather page_count()'s of each frag right before XDP prog call
>    ice: stop storing XDP verdict within ice_rx_buf
> 
>   drivers/net/ethernet/intel/ice/ice_txrx.c     | 128 +++++++++++-------
>   drivers/net/ethernet/intel/ice/ice_txrx.h     |   1 -
>   drivers/net/ethernet/intel/ice/ice_txrx_lib.h |  43 ------
>   3 files changed, 82 insertions(+), 90 deletions(-)
> 

It was a pleasure to read this series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>


      parent reply	other threads:[~2025-01-16 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 15:39 [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic Maciej Fijalkowski
2025-01-16 15:39 ` [PATCH intel-net 1/3] ice: put Rx buffers after being done with current frame Maciej Fijalkowski
2025-01-16 17:10   ` Petr Oros
2025-01-16 17:13     ` Maciej Fijalkowski
2025-01-16 15:39 ` [PATCH intel-net 2/3] ice: gather page_count()'s of each frag right before XDP prog call Maciej Fijalkowski
2025-01-16 15:39 ` [PATCH intel-net 3/3] ice: stop storing XDP verdict within ice_rx_buf Maciej Fijalkowski
2025-01-16 16:19 ` Przemek Kitszel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97dffc47-3363-4a0d-983a-5620fa5ad745@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jmaxwell@redhat.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=poros@redhat.com \
    --cc=xudu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox