netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Mathieu Malaterre <malat@debian.org>,
	"David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Meelis Roos <mroos@linux.ee>,
	schwab@linux-m68k.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] net: sungem: fix rx checksum support
Date: Wed, 20 Jun 2018 05:49:39 -0700	[thread overview]
Message-ID: <982b5081-e36d-6603-170e-6de8f7f9aa5c@gmail.com> (raw)
In-Reply-To: <CA+7wUswWV7FJ_n0Dd-p_2aK7m3xcUL0CJsokhCZH0J+scvJO3g@mail.gmail.com>



On 06/20/2018 04:22 AM, Mathieu Malaterre wrote:
 
> Thanks for the stable tag.
> 
> IMHO the commit message should have also reference commit 7ce5a27f2ef8
> ("Revert "net: Handle CHECKSUM_COMPLETE more adequately in
> pskb_trim_rcsum().""). Which means that commit 88078d98d1bb ("net:
> pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends") should be ready
> for stable also, since it seems that the only driver responsible for
> the revert was sungem.
> 
> my 2cts
> 

I disagree.

commit 88078d98d1bb is a performance improvement, and not needed for stable.

We might also discover another buggy driver later.

Thanks.

  reply	other threads:[~2018-06-20 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  2:18 [PATCH net] net: sungem: fix rx checksum support Eric Dumazet
2018-06-20  5:30 ` David Miller
2018-06-20 11:22   ` Mathieu Malaterre
2018-06-20 12:49     ` Eric Dumazet [this message]
2018-06-22  4:20   ` Eric Dumazet
2018-08-26 13:14     ` mroos
2018-08-27 16:57       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=982b5081-e36d-6603-170e-6de8f7f9aa5c@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=malat@debian.org \
    --cc=mroos@linux.ee \
    --cc=netdev@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).