From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] net: sungem: fix rx checksum support
Date: Wed, 20 Jun 2018 05:49:39 -0700
Message-ID: <982b5081-e36d-6603-170e-6de8f7f9aa5c@gmail.com>
References: <20180620021850.211683-1-edumazet@google.com>
 <20180620.143050.313454768369559179.davem@davemloft.net>
 <CA+7wUswWV7FJ_n0Dd-p_2aK7m3xcUL0CJsokhCZH0J+scvJO3g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org,
        Meelis Roos <mroos@linux.ee>, schwab@linux-m68k.org,
        eric.dumazet@gmail.com
To: Mathieu Malaterre <malat@debian.org>,
        "David S. Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f68.google.com ([209.85.160.68]:38053 "EHLO
        mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753651AbeFTMtm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Jun 2018 08:49:42 -0400
Received: by mail-pl0-f68.google.com with SMTP id d10-v6so1723991plo.5
        for <netdev@vger.kernel.org>; Wed, 20 Jun 2018 05:49:42 -0700 (PDT)
In-Reply-To: <CA+7wUswWV7FJ_n0Dd-p_2aK7m3xcUL0CJsokhCZH0J+scvJO3g@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/20/2018 04:22 AM, Mathieu Malaterre wrote:
 
> Thanks for the stable tag.
> 
> IMHO the commit message should have also reference commit 7ce5a27f2ef8
> ("Revert "net: Handle CHECKSUM_COMPLETE more adequately in
> pskb_trim_rcsum().""). Which means that commit 88078d98d1bb ("net:
> pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends") should be ready
> for stable also, since it seems that the only driver responsible for
> the revert was sungem.
> 
> my 2cts
> 

I disagree.

commit 88078d98d1bb is a performance improvement, and not needed for stable.

We might also discover another buggy driver later.

Thanks.