From: Giridhar Pemmasani <pgiri@yahoo.com>
To: Dale Farnsworth <dale@farnsworth.org>, akpm@linux-foundation.org
Cc: jeff@garzik.org, netdev@vger.kernel.org, giri@lmc.cs.sunysb.edu,
pgiri@yahoo.com
Subject: Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix
Date: Wed, 7 Mar 2007 16:05:13 -0800 (PST) [thread overview]
Message-ID: <983376.58847.qm@web32410.mail.mud.yahoo.com> (raw)
In-Reply-To: <20070306164638.GB22043@xyzzy.farnsworth.org>
--- Dale Farnsworth <dale@farnsworth.org> wrote:
> On Tue, Mar 06, 2007 at 02:42:02AM -0800, akpm@linux-foundation.org wrote:
> > From: Giridhar Pemmasani <giri@lmc.cs.sunysb.edu>
> >
> > During initialization, mv643xx driver registers IRQ before setting up
> tx/rx
> > rings. This causes kernel oops because mv643xx_poll, which gets called
> > right after registering IRQ, calls netif_rx_complete, which accesses the
> rx
> > ring (I don't have the oops message anymore; I just remember this
> sequence
> > of calls). Attached (tested) patch first initializes the rx/tx rings and
> > then registers the IRQ.
>
> I believe a better fix is to disable any pending interrupt sources
> before calling request_irq(). I sent the patch below to Giri for
> confirmation, but haven't heard back. I should've copied Andrew.
>
> Giri, have you had a chance to test this alternative patch?
I got a chance to test this patch today. I can confirm that this patch fixes
the issue reported.
Thanks,
Giri
____________________________________________________________________________________
The fish are biting.
Get more visitors on your site using Yahoo! Search Marketing.
http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php
next prev parent reply other threads:[~2007-03-08 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:42 [patch 18/19] mv643xx ethernet driver IRQ registration fix akpm
2007-03-06 11:16 ` Jeff Garzik
2007-03-06 16:46 ` Dale Farnsworth
2007-03-06 17:35 ` Giridhar Pemmasani
2007-03-08 0:05 ` Giridhar Pemmasani [this message]
2007-03-08 5:21 ` [PATCH] mv643xx: Clear pending interrupts before calling request_irq Dale Farnsworth
2007-03-09 16:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983376.58847.qm@web32410.mail.mud.yahoo.com \
--to=pgiri@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=dale@farnsworth.org \
--cc=giri@lmc.cs.sunysb.edu \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).