From: David Ahern <dsahern@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
xeb@mail.ru, David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Menglong Dong <imagedong@tencent.com>,
Eric Dumazet <edumazet@google.com>, Martin Lau <kafai@fb.com>,
Talal Ahmad <talalahmad@google.com>,
Kees Cook <keescook@chromium.org>,
Alexander Lobakin <alobakin@pm.me>,
Hao Peng <flyingpeng@tencent.com>,
Mengen Sun <mengensun@tencent.com>,
dongli.zhang@oracle.com, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Biao Jiang <benbjiang@tencent.com>
Subject: Re: [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol
Date: Fri, 18 Mar 2022 16:33:26 -0600 [thread overview]
Message-ID: <98450e8a-b3e1-22d7-86fb-3c8456a36018@kernel.org> (raw)
In-Reply-To: <CADxym3bGVebdCTCXxg3xEcPwdfSQADLyPbLTJnPnwn+phqGp3A@mail.gmail.com>
On 3/18/22 1:26 AM, Menglong Dong wrote:
> Yeah, PTYPE seems not suitable. I mean that replace SKB_DROP_REASON_PTYPE_ABSENT
> that is used in __netif_receive_skb_core() with L3_PROTO, which means no L3
> protocol handler (or other device handler) is not found for the
> packet. This seems more
> friendly and not code based.
>
>>> And use SKB_DROP_REASON_L4_PROTO for the L4 protocol problem,
>>> such as GRE version not supported, ICMP type not supported, etc.
> Is this L4_PROTO followed by anyone?
how about just a generic
SKB_DROP_REASON_UNHANDLED_PROTO /* protocol not implemented
* or not supported
*/
in place of current PTYPE_ABSENT (so a rename to remove a Linux code
reference), and then use it for no L3 protocol handler, no L4 protocol
handler, version extensions etc. The instruction pointer to symbol gives
the context of the unsupported protocol.
next prev parent reply other threads:[~2022-03-18 22:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 6:31 [PATCH net-next v3 0/3] net: icmp: add skb drop reasons to icmp menglong8.dong
2022-03-16 6:31 ` [PATCH net-next v3 1/3] net: sock: introduce sock_queue_rcv_skb_reason() menglong8.dong
2022-03-16 6:31 ` [PATCH net-next v3 2/3] net: icmp: introduce __ping_queue_rcv_skb() to report drop reasons menglong8.dong
2022-03-17 3:56 ` David Ahern
2022-03-17 5:25 ` Menglong Dong
2022-03-17 8:33 ` Paolo Abeni
2022-03-17 8:36 ` Menglong Dong
2022-03-16 6:31 ` [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol menglong8.dong
2022-03-17 3:18 ` Jakub Kicinski
2022-03-17 3:35 ` David Ahern
2022-03-17 4:05 ` Jakub Kicinski
2022-03-17 6:02 ` Menglong Dong
2022-03-17 14:48 ` David Ahern
2022-03-17 14:53 ` David Laight
2022-03-17 15:49 ` David Ahern
2022-03-18 1:37 ` Menglong Dong
2022-03-18 4:10 ` David Ahern
2022-03-18 7:26 ` Menglong Dong
2022-03-18 22:33 ` David Ahern [this message]
2022-03-20 13:27 ` Menglong Dong
2022-03-17 5:57 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98450e8a-b3e1-22d7-86fb-3c8456a36018@kernel.org \
--to=dsahern@kernel.org \
--cc=alobakin@pm.me \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).