Re: [RFC net-next 1/3] net: usb: divorce private data and cdc state in usbnet

[Oliver Neukum <oneukum@suse.com>]

Hi,

On 10.02.26 17:27, Bjørn Mork wrote:
> Oliver Neukum <oneukum@suse.com> writes:
> 
  
> But I don't understand why you make struct cdc_state special.  That's
> just confusing.

Because technically it is a layering violation to put cdc stuff
into usbnet. I want to do so that I can remove the exported symbols
from the cdc_X drivers and put them cleanly into usbnet.
That is the medium term plan.

> I know I intentionally made the "control" and "data" fields of
> "struct qmi_wwan_state" position and name compatible with
> "struct cdc_state". Maybe not very important.  But adds to the
> confusion if we end up with a double set of those fields.
> 
> Or should the qmi_wwan driver split out the
>          struct usb_interface            *control;
>          struct usb_interface            *data;
> 
> part of its private data and put those into "cdc", allowing us to reduce
> "struct qmi_wwan_state" from 5 to 3 longs?  I don't think that's a very
> good idea...

Well, QMI is not CDC. No use pretending.
But we could put them into struct usbnet as primary and secondary

	Regards
		Oliver