public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Chuck Lever	 <chuck.lever@oracle.com>,
	NeilBrown <neil@brown.name>,
	 linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, 	llvm@lists.linux.dev
Cc: Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,
	 Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	"David S. Miller"	 <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski	 <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman	 <horms@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers	 <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues
Date: Wed, 04 Feb 2026 09:28:28 -0500	[thread overview]
Message-ID: <9859fe54fded87e720e375b1b267908437480f47.camel@kernel.org> (raw)
In-Reply-To: <20260204094500.2443455-1-andriy.shevchenko@linux.intel.com>

On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote:
> Compiler is not happy about unused variables (especially when
> dprintk() call is defined as no-op). Here is the series to
> address the issues.
> 
> Changelog v2:
> - added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
> - united separate patches in the series
> - collected tags (Geert)
> 
> v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com
> v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com
> 
> Andy Shevchenko (3):
>   nfs/blocklayout: Fix compilation error (`make W=1`) in
>     bl_write_pagelist()
>   sunrpc: Kill RPC_IFDEBUG()
>   sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
> 
>  fs/lockd/svclock.c                       |  5 +++++
>  fs/nfs/blocklayout/blocklayout.c         |  4 +---
>  fs/nfsd/nfsfh.c                          |  9 +++++---
>  include/linux/sunrpc/debug.h             | 10 +++++----
>  net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------
>  5 files changed, 32 insertions(+), 23 deletions(-)

These all look like good changes to me. The first patch should go to
Trond/Anna and Chuck will probably pick up the other two?

Reviewed-by: Jeff Layton <jlayton@kernel.org>

  parent reply	other threads:[~2026-02-04 14:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  9:41 [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues Andy Shevchenko
2026-02-04  9:41 ` [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist() Andy Shevchenko
2026-02-04 15:53   ` Anna Schumaker
2026-02-04 16:44     ` Andy Shevchenko
2026-02-04  9:41 ` [PATCH v2 2/3] sunrpc: Kill RPC_IFDEBUG() Andy Shevchenko
2026-02-04  9:41 ` [PATCH v2 3/3] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op Andy Shevchenko
2026-02-04 16:46   ` Andy Shevchenko
2026-02-04 16:58     ` Andy Shevchenko
2026-02-04 18:29       ` Chuck Lever
2026-02-04 20:25         ` Andy Shevchenko
2026-02-04 10:02 ` [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues Andy Shevchenko
2026-02-04 14:28 ` Jeff Layton [this message]
2026-02-04 14:30   ` Chuck Lever
2026-02-04 14:45     ` Andy Shevchenko
2026-02-04 14:32   ` Andy Shevchenko
2026-02-04 15:42 ` Chuck Lever
2026-02-04 15:51   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9859fe54fded87e720e375b1b267908437480f47.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=okorniev@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox