From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B3DC282CD for ; Tue, 29 Jan 2019 00:12:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DF2B2175B for ; Tue, 29 Jan 2019 00:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbfA2AMz (ORCPT ); Mon, 28 Jan 2019 19:12:55 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:52398 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726803AbfA2AMt (ORCPT ); Mon, 28 Jan 2019 19:12:49 -0500 Received: from mr6.cc.vt.edu (mr6.cc.ipv6.vt.edu [IPv6:2607:b400:92:8500:0:af:2d00:4488]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x0SNZOti000499 for ; Mon, 28 Jan 2019 18:35:24 -0500 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mr6.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x0SNZJqg029982 for ; Mon, 28 Jan 2019 18:35:24 -0500 Received: by mail-qt1-f198.google.com with SMTP id 41so22306172qto.17 for ; Mon, 28 Jan 2019 15:35:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=UDEF/0d3Q0zZWlBm2eHzE6Yozy0EgOGcdjjKxY0nlWo=; b=Q6nmxTSSFMjSNDw1IW6NDWAM+P7IT/CEWFnsxBaYnC0lW7b+ZqL4FfJgZCc/HodQ8X G51/mPeWFL/bW2YBa5F5RV8fhaacy3MQz7lYMzmKG91LhLaFiy0aOwOCf5lWJMJSbPKt uSD3RKsqyXbKOhNmzfnFIsXuzAEXVs0tn+6f/IuTppsKrrsB0FF6JnMqkL3sZCKTOlvD TDQc5S4ZEE9ooKgjdnlBYPW4HAFhlSBAp6gSauwMLtBy/FA4mLjH//eQthmUPeQ0LcP+ jyJvlDBUH4qtVDpty5+2VPIbs03uvawPu/1RL/DWsO9+mE2VnGin9L+R11mgXr0X2k9g 9A2Q== X-Gm-Message-State: AJcUukfS2YigAttBzi/eCzADl/Huk1kb3MnG62pFVFxkMA659Z4p1aiY M2a0G91lTNSXI5dJiQ3iDyGNys2qlriMN9KKkr6U58kab9bAa0qQPCgwt6X+Pmj+EHXqb8lWbgV eAJLn1ZvnEkdwNsSEb+KZIwQVRnQ= X-Received: by 2002:aed:384a:: with SMTP id j68mr23272278qte.171.1548718519094; Mon, 28 Jan 2019 15:35:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN56jwhHp4RgzCY6/zt4lJuhZGnty+lgoGhDyVmUo1lOJvhW0C9W91Ha8t27P2MbPdlaJrBnVQ== X-Received: by 2002:aed:384a:: with SMTP id j68mr23272263qte.171.1548718518938; Mon, 28 Jan 2019 15:35:18 -0800 (PST) Received: from turing-police.cc.vt.edu ([2601:5c0:c001:4341::936]) by smtp.gmail.com with ESMTPSA id z18sm69894537qkz.96.2019.01.28.15.35.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 15:35:17 -0800 (PST) From: valdis.kletnieks@vt.edu X-Google-Original-From: Valdis.Kletnieks@vt.edu X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Song Liu cc: Alexei Starovoitov , Daniel Borkmann , Networking , open list Subject: Re: [PATCH] bpf/core.c - silence warning messages In-reply-to: References: <31468.1548648675@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 28 Jan 2019 18:35:16 -0500 Message-ID: <9865.1548718516@turing-police.cc.vt.edu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said: > On Sun, Jan 27, 2019 at 8:43 PM wrote: > > The attached patch silences the warnings, because we *know* we're overwriting > > the default initializer. That leaves bpf/core.c with only 6 other warnings, > > which become more visible in comparison. > > My concern is that this will also mute the warning for other parts of > bpf/core.c. I checked and there weren't any warnings for other parts of the file. Also, this message doesn't even happen unless you build with W=1, which apparently happens so rarely that nobody else has submitted a patch. Is there a high likelihood that another overwrite of an initializer is going to be included in the source? > Maybe we should move bpf_opcode_in_insntable() to a separate file, and mute > warning for that file? Seems to be overkill - the intent of this patch was mostly to make the *other* warnings issued with W=1 more noticable.