From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@kernel.org>
Subject: Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support
Date: Thu, 13 Sep 2018 10:03:06 -0500
Message-ID: <9868264b-b337-1880-fba2-604b9d73c6c8@kernel.org>
References: <1536829493-10088-1-git-send-email-dongsheng.wang@hxt-semitech.com>
 <1536829493-10088-3-git-send-email-dongsheng.wang@hxt-semitech.com>
 <20180913124229.GD11702@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, yu.zheng@hxt-semitech.com,
        netdev@vger.kernel.org
To: Andrew Lunn <andrew@lunn.ch>,
        Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:40224 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726824AbeIMUNC (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 13 Sep 2018 16:13:02 -0400
In-Reply-To: <20180913124229.GD11702@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 9/13/18 7:42 AM, Andrew Lunn wrote:
> This is a pretty big patch, and is hard to review. Could you try to
> break it up into a number of smaller patches. You could for example
> first refactor emacs_phy_config(), without making any functional
> changes. Then add the sharing. Maybe do OF an ACPI in different
> patches?

Yes, please.