* struct mii_if_info in usbnet.h
@ 2020-11-26 14:59 Oliver Neukum
0 siblings, 0 replies; only message in thread
From: Oliver Neukum @ 2020-11-26 14:59 UTC (permalink / raw)
To: linux-usb, netdev; +Cc: hayeswang, hkallweit1, tremyfr
Hi,
I was looking at usbnet_get_link_ksettings() and it seems in hindsight
that the idea it rests upon makes an assumption about the hardware
that was at the time it was introduced was often true, but today
isn't.
struct usbnet contains a member struct mii_if_info. Why? That makes
a pretty strong assumption about the hardware. Inparticular I see
no way to sanely implement mdio_read() and mdio_write() on hardware
this assumption does not fit.
On this hardware usbnet_get_link_ksettings() does not do its job.
So what is to be done? Technically it is a layering violation. Yet
it is obviously useful to many drivers?
Suggestions?
Regards
Oliver
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-26 15:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-26 14:59 struct mii_if_info in usbnet.h Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).