From: Sebastien Laveze <sebastien.laveze@oss.nxp.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yangbo.lu@nxp.com, yannick.vignon@oss.nxp.com,
rui.sousa@oss.nxp.com
Subject: Re: [PATCH net-next] ptp: add vclock timestamp conversion IOCTL
Date: Tue, 28 Sep 2021 13:50:23 +0200 [thread overview]
Message-ID: <98a91f5889b346f7a3b347bebb9aab56bddfd6dc.camel@oss.nxp.com> (raw)
In-Reply-To: <20210927202304.GC11172@hoboy.vegasvil.org>
On Mon, 2021-09-27 at 13:23 -0700, Richard Cochran wrote:
> What you really want is the socket to return more than one time stamp.
> So why not do that instead?
>
> Right now, the SO_TIMESTAMPING has an array of
>
> struct timespec ts[3] =
> [0] SOFTWARE
> [1] LEGACY (unused)
> [2] HARDWARE
>
> You can extend that to have
>
> [0] SOFTWARE
> [1] LEGACY (unused)
> [2] HARDWARE (vclock 0)
> [3] HARDWARE (vclock 1)
> [4] HARDWARE (vclock 2)
> ...
> [N] HARDWARE (vclock N-2)
>
> You could store the selected vclocks in a bit mask associated with the socket.
>
> Hm?
Yes that would do it. Only drawback is that ALL rx and tx timestamps
are converted to the N domains instead of a few as needed.
Before going in this direction, is this a change that you really see as
worthwile for virtual clocks and timetamping support ?
What approach do you have in mind for multi-domain support with the
common CMLDS layer ?
Thanks,
Seb
next prev parent reply other threads:[~2021-09-28 11:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 9:32 [PATCH net-next] ptp: add vclock timestamp conversion IOCTL Sebastien Laveze
2021-09-27 14:59 ` Richard Cochran
2021-09-27 16:00 ` Sebastien Laveze
2021-09-27 20:23 ` Richard Cochran
2021-09-28 11:50 ` Sebastien Laveze [this message]
2021-09-28 13:31 ` Richard Cochran
2021-09-29 15:00 ` Sebastien Laveze
2021-09-30 14:35 ` Richard Cochran
2021-10-07 13:31 ` Sebastien Laveze
2021-10-07 20:19 ` Richard Cochran
2021-10-08 7:13 ` Sebastien Laveze
2021-10-09 18:24 ` Richard Cochran
2021-10-09 18:25 ` Richard Cochran
2021-10-11 12:58 ` Richard Cochran
2021-10-12 16:14 ` Richard Cochran
2021-10-13 9:56 ` Sebastien Laveze
2021-10-13 13:10 ` Richard Cochran
2021-10-13 13:28 ` Sebastien Laveze
2021-10-13 17:54 ` Richard Cochran
2021-10-14 13:27 ` Sebastien Laveze
2021-09-27 18:28 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a91f5889b346f7a3b347bebb9aab56bddfd6dc.camel@oss.nxp.com \
--to=sebastien.laveze@oss.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@oss.nxp.com \
--cc=yangbo.lu@nxp.com \
--cc=yannick.vignon@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).