From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792430406; b=QMzTECqXjuqpDQ811KLkTbkO/0ZawuN8Ndx4ceGdZF5t4cfd8SB+Km5XrH9cUg0IB6WP 6yoCgEAPiHIrg4ZHz/Ybqp1GvUGVfWPPrKCgKFd9ER1I7GWLtBWSAofqTRod4V+eMJT4R pF0FwZ6xn1vcU/RB/06A5UX0j5/Pn6XJ1rqLRljjLHLTAjP8EbHbYOTZR52vmiln26ghH zVdjOx9YgGgBqtYjjZImWy0qtzZgUhT+4jRsvaQ8VJ2u1p38mbqtwo9d/Cmj5rIRJXwol Asjwb7IJHbOaBL2aA/0vKsqcSDNk9yF2xp2GKHcogiAIoSeR4K34PLk8w38KXKnTg6w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792430406; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding:X-Scanned-By; bh=NZLIGIiPN0hTXUeW4qoosN9u/LtYMyrcbQzE3iavz+s=; b=sCNbitoPmELXCzAML82Hm2nULSSDHKqC27xMRIjZVDq0eEetT906+HU/8m2a41sJeoIK CUGFOpwJSLpBJsLp/Pq/nQ+5UCYkwLNMWt+Fenp/JCuajQwVbgSmB10yVSTqGfyrWvvPN Kq92R2zIZSPhQcthVOGjtk6qSwNxN2HoDJEbEa4vaDq2Z+8YA5I1/cIlDaDNn3ji9JsAt N4iqlPv/Tv8usQGaW5mUfeIZjz6Eu6+UCJ7VX06oU7hEM7uz04YrnI3lXpecmPrlJJ/0u 8E6Xzoq4k0I6kBkQHYqStgz66Sg1Rpg6ouwiWgOCa8S1MxknawyRWWP8uEMsHTaFJmA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="BPJ2Agi/"; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7243606A31E for ; Mon, 19 Oct 2026 17:20:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E7243606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BPJ2Agi/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792430405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NZLIGIiPN0hTXUeW4qoosN9u/LtYMyrcbQzE3iavz+s=; b=BPJ2Agi/l9Uu9DL1nIgMkrftCGsb/ZnXOItQTirynS6UKHycGTUUhbsXv6Qt7iX2htO6WK 0hEXUbIG/3q5H5wUEZqhCW99K7VNxT+EL49MFt6nu6okK7z/g1Tr0Yw+CsOoZTJ8F6d/mP nTFslP3p/tfLNrzJwyjI9LbH2v0+5pU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-0lDsr6cSNI2FmoY6_iU2LA-1; Mon, 19 Oct 2026 17:20:00 +0000 X-MC-Unique: 0lDsr6cSNI2FmoY6_iU2LA-1 X-Mimecast-MFC-AGG-ID: 0lDsr6cSNI2FmoY6_iU2LA_1792430398 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49DA71955F7E; Mon, 19 Oct 2026 17:19:57 +0000 (UTC) Received: from [100.91.101.41] (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9995F180057F; Mon, 19 Oct 2026 17:19:52 +0000 (UTC) Message-ID: <98c195a3-9cf4-4d4f-80c2-5186055454fe@redhat.com> Date: Mon, 19 Oct 2026 19:19:51 +0200 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net/mlx5: DPLL, fix fractional frequency offset scaling To: Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni Cc: Arkadiusz Kubalewski , Carolina Jubran , Gal Pressman , Jiri Pirko , Jiri Pirko , Leon Romanovsky , open list , linux-rdma@vger.kernel.org, Mark Bloch , Saeed Mahameed , Vadim Fedorenko References: <20261015074035.1092340-1-tariqt@nvidia.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20261015074035.1092340-1-tariqt@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 10/15/26 09:40, Tariq Toukan wrote: > From: Carolina Jubran > > The frequency_diff is reported by firmware in parts-per-trillion, which > is exactly what the DPLL core now expects from the ffo_get callback. > > Commit bc443c253fcd ("dpll: expose fractional frequency offset in ppt") > switched the callback contract to ppt but assumed frequency_diff was in > ppm and scaled it by 1000000 to "convert" it. Since the value was > already ppt, this makes both exported attributes wrong. > > Report frequency_diff as is and let the core divide it down for the > legacy ppm attribute. > > Fixes: f035dca34ede ("net/mlx5: DPLL, Implement fractional frequency offset get pin op") > Signed-off-by: Carolina Jubran > Reviewed-by: Jiri Pirko > Signed-off-by: Tariq Toukan > --- It’s a pity we didn’t implement FFO in ppt units right from the start... We wouldn’t have to carry a duplicate attribute in ppm units now for the sake of backward compatibility. Anyway... Reviewed-by: Ivan Vecera