From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:46548 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932471AbeBTEJh (ORCPT ); Mon, 19 Feb 2018 23:09:37 -0500 Received: by mail-pg0-f47.google.com with SMTP id m1so2582962pgp.13 for ; Mon, 19 Feb 2018 20:09:37 -0800 (PST) Subject: Re: [PATCH iproute2-next] ip link: add support to display extended tun attributes To: Serhey Popovych , Sabrina Dubroca , netdev@vger.kernel.org Cc: sbrivio@redhat.com References: <8bea9df2ab3ee8202f6696fdbea331abacdbb8b5.1518775084.git.sd@queasysnail.net> <73c75acb-4607-d405-8a0d-71b2904e1f64@gmail.com> From: David Ahern Message-ID: <98d79dd9-9e22-43aa-0811-913a77e5fd05@gmail.com> Date: Mon, 19 Feb 2018 21:09:30 -0700 MIME-Version: 1.0 In-Reply-To: <73c75acb-4607-d405-8a0d-71b2904e1f64@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/19/18 3:19 PM, Serhey Popovych wrote: > I get following checkpatch.pl warnings: > > WARNING: Missing a blank line after declarations > #73: FILE: ip/iptuntap.c:497: > + __u8 mq = rta_getattr_u8(tb[IFLA_TUN_MULTI_QUEUE]); > + if (!mq) > > WARNING: Missing a blank line after declarations > #80: FILE: ip/iptuntap.c:504: > + __u32 numq = rta_getattr_u32(tb[IFLA_TUN_NUM_QUEUES]); > + fprintf(f, "numqueues %u ", numq); > > WARNING: Missing a blank line after declarations > #85: FILE: ip/iptuntap.c:509: > + __u32 numq = > rta_getattr_u32(tb[IFLA_TUN_NUM_DISABLED_QUEUES]); > + fprintf(f, "numdisabled %u ", numq); > > maybe they should be fixed before accepting? yes. Please fix; headers have been updated to 4.16.0-rc2+, f5c0c6f4299f, so you can drop those from v2