From: David Howells <dhowells@redhat.com>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
NETDEV <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] RXRPC: Use skb_queue_walk_safe()
Date: Thu, 22 May 2008 15:10:56 +0100 [thread overview]
Message-ID: <9913.1211465456@redhat.com> (raw)
In-Reply-To: <4835457B.3050300@cn.fujitsu.com>
Wang Chen <wangchen@cn.fujitsu.com> wrote:
> Because the list could be modified inside the loop, use
> skb_queue_walk_safe().
This is unnecessary. If skb_insert() is called in the loop, the very next
line is a goto that exits the loop immediately.
David
prev parent reply other threads:[~2008-05-22 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 10:05 [PATCH] RXRPC: Use skb_queue_walk_safe() Wang Chen
2008-05-22 14:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9913.1211465456@redhat.com \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-afs@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).