From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Emil Tantilov <emil.s.tantilov@intel.com>
Subject: Re: ixgbe: Replace LRO with GRO
Date: Fri, 16 Jan 2009 15:32:56 -0800 [thread overview]
Message-ID: <9929d2390901161532j57528215mdb01f38be1bd4c7f@mail.gmail.com> (raw)
In-Reply-To: <20090115034619.GA28267@gondor.apana.org.au>
On Wed, Jan 14, 2009 at 7:46 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Wed, Jan 14, 2009 at 07:44:12PM +1100, Herbert Xu wrote:
>>
>> ixgbe: Replace LRO with GRO
>
> I forgot to delete the Kconfig dependency, here is an updated
> version.
>
> ixgbe: Replace LRO with GRO
>
> This patch makes igb invoke the GRO hooks instead of LRO. As
> GRO has a compatible external interface to LRO this is a very
> straightforward replacement.
>
> As GRO uses the napi structure to track the held packets, I've
> modified the code paths involved to pass that along.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
Adding Emil to provide further testing details...
We are seeing data corruption with this patch applied. When we
disable GRO the data corruption goes away.
We have this simple ftp test that does put/get and then compares
md5sum of the file. The file we get back is different then the one we
sent with GRO enabled. The file is around 34MB. Note that we don't
always see the corruption with 30meg file, but it becomes more
apparent as we increase the size of the file.
If this helps - Emil did a diff off of a hexdump output between the
sent and received file. Looks like the receive was cut off at the end:
--- sent.dump 2009-01-16 11:48:50.000000000 -0800
+++ received.dump 2009-01-16 11:48:47.000000000 -0800
@@ -62714,43 +62714,5 @@
00f4f90 0000 0000 ffff ffff 0000 0000 ffff ffff 00f4fa0 0000 0000
ffff ffff 0000 0000 ffff ffff 00f4fb0 0000 0000 ffff ffff 0000 0000
ffff ffff -00f4fc0 0000 0000 ffff ffff 0000 0000 ffff ffff -00f4fd0
0000 0000 ffff ffff 0000 0000 ffff ffff -00f4fe0 0000 0000 ffff ffff
0000 0000 ffff ffff -00f4ff0 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f5000 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5010 0000 0000
ffff ffff 0000 0000 ffff ffff -00f5020 0000 0000 ffff ffff 0000 0000
ffff ffff -00f5030 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5040
0000 0000 ffff ffff 0000 0000 ffff ffff -00f5050 0000 0000 ffff ffff
0000 0000 ffff ffff -00f5060 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f5070 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5080 0000 0000
ffff ffff 0000 0000 ffff ffff -00f5090 0000 0000 ffff ffff 0000 0000
ffff ffff -00f50a0 0000 0000 ffff ffff 0000 0000 ffff ffff -00f50b0
0000 0000 ffff ffff 0000 0000 ffff ffff -00f50c0 0000 0000 ffff ffff
0000 0000 ffff ffff -00f50d0 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f50e0 0000 0000 ffff ffff 0000 0000 ffff ffff -00f50f0 0000 0000
ffff ffff 0000 0000 ffff ffff -00f5100 0000 0000 ffff ffff 0000 0000
ffff ffff -00f5110 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5120
0000 0000 ffff ffff 0000 0000 ffff ffff -00f5130 0000 0000 ffff ffff
0000 0000 ffff ffff -00f5140 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f5150 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5160 0000 0000
ffff ffff 0000 0000 ffff ffff -00f5170 0000 0000 ffff ffff 0000 0000
ffff ffff -00f5180 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5190
0000 0000 ffff ffff 0000 0000 ffff ffff -00f51a0 0000 0000 ffff ffff
0000 0000 ffff ffff -00f51b0 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f51c0 0000 0000 ffff ffff 0000 0000 ffff ffff -00f51d0 0000 0000
ffff ffff 0000 0000 ffff ffff -00f51e0 0000 0000 ffff ffff 0000 0000
ffff ffff -00f51f0 0000 0000 ffff ffff 0000 0000 ffff ffff -00f5200
0000 0000 ffff ffff 0000 0000 ffff ffff -00f5210 0000 0000 ffff ffff
0000 0000 ffff ffff -00f5220 0000 0000 ffff ffff 0000 0000 ffff ffff
-00f5230
+00f4fc0 0000 0000 ffff ffff
+00f4fc8
--
Cheers,
Jeff
next prev parent reply other threads:[~2009-01-16 23:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 9:26 [1/2] e1000e: Invoke VLAN GRO handler Herbert Xu
2009-01-13 9:28 ` [2/2] igb: Replace LRO with GRO Herbert Xu
2009-01-14 8:44 ` ixgbe: " Herbert Xu
2009-01-14 11:53 ` Jeff Kirsher
2009-01-15 3:46 ` Herbert Xu
2009-01-15 4:22 ` Herbert Xu
2009-01-19 5:49 ` David Miller
2009-01-16 23:32 ` Jeff Kirsher [this message]
2009-01-17 0:36 ` Herbert Xu
2009-01-17 1:06 ` Tantilov, Emil S
2009-01-17 3:45 ` Herbert Xu
2009-01-17 8:07 ` Tantilov, Emil S
2009-01-17 9:52 ` Herbert Xu
2009-01-17 13:04 ` Herbert Xu
2009-01-20 23:00 ` Tantilov, Emil S
2009-01-17 15:44 ` Tantilov, Emil S
2009-01-14 11:49 ` [2/2] igb: " Jeff Kirsher
2009-01-14 12:36 ` Herbert Xu
2009-01-15 0:03 ` Jeff Kirsher
2009-01-15 0:32 ` Herbert Xu
2009-01-15 1:35 ` Jeff Kirsher
2009-01-15 1:56 ` David Miller
2009-01-15 2:02 ` Jeff Kirsher
2009-01-15 4:40 ` David Miller
2009-01-19 5:47 ` David Miller
2009-01-19 11:16 ` Herbert Xu
2009-01-19 22:34 ` Jeff Kirsher
2009-01-19 23:21 ` David Miller
2009-01-15 4:24 ` sfc: " Herbert Xu
2009-01-19 5:50 ` David Miller
2009-01-19 14:40 ` Ben Hutchings
2009-01-19 21:29 ` David Miller
2009-01-19 22:12 ` Harvey Harrison
2009-01-19 23:27 ` David Miller
2009-01-20 0:57 ` Stephen Rothwell
2009-01-15 4:38 ` [1/2] e1000e: Invoke VLAN GRO handler David Miller
2009-01-15 6:59 ` cxgb3: Replace LRO with GRO Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390901161532j57528215mdb01f38be1bd4c7f@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).