Re: gro: Fix handling of imprecisely split packets

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

On Sat, Jan 31, 2009 at 11:01 PM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
> Hi Jeff:
>
> Please let me know if the ixgbe problems persist with this patch
> against net-next.
>
> gro: Fix handling of imprecisely split packets
>
> The commit 89a1b249edcf9be884e71f92df84d48355c576aa (gro: Avoid
> copying headers of unmerged packets) only worked for packets
> which are either completely linear, completely non-linear, or
> packets which exactly split at the boundary between headers and
> payload.
>
> Anything else would cause bits in the header to go missing if
> the packet is held by GRO.
>
> This may have broken drivers such as ixgbe.
>
> This patch fixes the places that assumed or only worked with
> the above cases.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>

Thanks Herbert!

I have applied the patch and hopefully I will have more information to
you soon.  At the very least, I should have updated information for
you on Monday.

-- 
Cheers,
Jeff