From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: gro: Fix handling of imprecisely split packets
Date: Sun, 1 Feb 2009 01:29:42 -0800 [thread overview]
Message-ID: <9929d2390902010129q64aef7f8hecbacacfdb7b6d6f@mail.gmail.com> (raw)
In-Reply-To: <20090201.012510.119374504.davem@davemloft.net>
On Sun, Feb 1, 2009 at 1:25 AM, David Miller <davem@davemloft.net> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 31 Jan 2009 23:49:49 -0800
>
>> On Sat, Jan 31, 2009 at 11:01 PM, Herbert Xu
>> <herbert@gondor.apana.org.au> wrote:
>> > Hi Jeff:
>> >
>> > Please let me know if the ixgbe problems persist with this patch
>> > against net-next.
>> >
>> > gro: Fix handling of imprecisely split packets
>> >
>> > The commit 89a1b249edcf9be884e71f92df84d48355c576aa (gro: Avoid
>> > copying headers of unmerged packets) only worked for packets
>> > which are either completely linear, completely non-linear, or
>> > packets which exactly split at the boundary between headers and
>> > payload.
>> >
>> > Anything else would cause bits in the header to go missing if
>> > the packet is held by GRO.
>> >
>> > This may have broken drivers such as ixgbe.
>> >
>> > This patch fixes the places that assumed or only worked with
>> > the above cases.
>> >
>> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>> >
>>
>> Thanks Herbert!
>>
>> I have applied the patch and hopefully I will have more information to
>> you soon. At the very least, I should have updated information for
>> you on Monday.
>
> Meanwhile I'll toss Herbert's patch into net-next-2.6
> --
Sounds good to me, thanks Dave.
--
Cheers,
Jeff
prev parent reply other threads:[~2009-02-01 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 7:01 gro: Fix handling of imprecisely split packets Herbert Xu
2009-02-01 7:49 ` Jeff Kirsher
2009-02-01 9:25 ` David Miller
2009-02-01 9:29 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390902010129q64aef7f8hecbacacfdb7b6d6f@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).