From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Maciej Sosnowski <maciej.sosnowski@intel.com>
Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] dca: redesign locks
Date: Mon, 2 Feb 2009 21:58:01 -0800 [thread overview]
Message-ID: <9929d2390902022158v47bdc745h7267c9c6ad6020e7@mail.gmail.com> (raw)
In-Reply-To: <20090202171312.1559.65827.stgit@linux.site>
On Mon, Feb 2, 2009 at 9:14 AM, Maciej Sosnowski
<maciej.sosnowski@intel.com> wrote:
> Change spin_locks to irqsave to prevent dead-locks.
> Protect adding and deleting to/from dca_providers list.
> Drop the lock during dca_sysfs_add_req() and dca_sysfs_remove_req() calls
> as they might sleep (use GFP_KERNEL allocation).
>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> ---
>
> drivers/dca/dca-core.c | 51 +++++++++++++++++++++++++++++++-----------------
> 1 files changed, 33 insertions(+), 18 deletions(-)
>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
--
Cheers,
Jeff
next prev parent reply other threads:[~2009-02-03 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 17:14 [PATCH] dca: redesign locks Maciej Sosnowski
2009-02-03 5:58 ` Jeff Kirsher [this message]
2009-02-03 7:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390902022158v47bdc745h7267c9c6ad6020e7@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).