From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
Date: Wed, 8 Apr 2009 19:26:08 -0700 [thread overview]
Message-ID: <9929d2390904081926m6176d705y481085318a930087@mail.gmail.com> (raw)
In-Reply-To: <75761e1f53ed07c43a977d98b54d6467d8896530.1239165870.git.tony@bakeyournoodle.com>
On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds <tony@bakeyournoodle.com> wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right. Bracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
Thanks, I will add it to my queue of ixgbe patches.
Remember to CC netdev mailing list for networking patches.
--
Cheers,
Jeff
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
next prev parent reply other threads:[~2009-04-09 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <75761e1f53ed07c43a977d98b54d6467d8896530.1239165870.git.tony@bakeyournoodle.com>
2009-04-08 17:52 ` [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() Brandeburg, Jesse
2009-04-09 2:26 ` Jeff Kirsher [this message]
2009-04-09 3:49 ` [E1000-devel] " Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390904081926m6176d705y481085318a930087@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).