From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
e1000-devel@lists.sourceforge.net, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, peter.p.waskiewicz.jr@intel.com,
john.ronciak@intel.com
Subject: Re: [PATCH] igb: Record hardware RX overruns in net_stats
Date: Tue, 5 May 2009 11:47:09 -0700 [thread overview]
Message-ID: <9929d2390905051147y71f34e4bu9f63edc1e5a253a2@mail.gmail.com> (raw)
In-Reply-To: <1241435206.8115.104.camel@localhost.localdomain>
On Mon, May 4, 2009 at 4:06 AM, Jesper Dangaard Brouer <hawk@comx.dk> wrote:
>
> Hardware RX fifo overruns for the 82576 is stored in the
> RNBC (Receive No Buffers Count) register.
>
> I choose the store the RNBC value in net_stats.rx_fifo_errors.
>
> Saving the stats in dev->net_stats makes it visible via
> /proc/net/dev as "fifo", and thus viewable to ifconfig
> as "overruns" and 'netstat -i' as "RX-OVR".
>
> The Receive No Buffers Count (RNBC) can already be queried by
> ethtool -S as "rx_no_buffer_count".
>
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
> ---
>
NAK. RNBC is not a counter for buffer overruns, and so should not be
counted as such.
--
Cheers,
Jeff
next prev parent reply other threads:[~2009-05-05 18:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 11:06 [PATCH] igb: Record hardware RX overruns in net_stats Jesper Dangaard Brouer
2009-05-05 18:47 ` Jeff Kirsher [this message]
2009-05-05 18:58 ` David Miller
2009-05-05 21:24 ` Jesper Dangaard Brouer
2009-05-05 21:32 ` Jeff Kirsher
2009-05-05 21:35 ` David Miller
2009-05-06 7:46 ` Jesper Dangaard Brouer
2009-05-06 8:11 ` Waskiewicz Jr, Peter P
2009-05-06 13:09 ` Jesper Dangaard Brouer
2009-05-06 20:59 ` Jesper Dangaard Brouer
2009-05-06 21:24 ` Waskiewicz Jr, Peter P
2009-05-05 22:38 ` Ronciak, John
2009-05-06 8:12 ` Jesper Dangaard Brouer
2009-05-06 8:56 ` [PATCH v2] igb: Record host memory receive overflow " Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390905051147y71f34e4bu9f63edc1e5a253a2@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=hawk@comx.dk \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox