From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH 0/2] igb: drop stats due to OS cannot keep up Date: Thu, 14 May 2009 15:43:15 -0700 Message-ID: <9929d2390905141543g6f5adc32ndf65870bd49d83ea@mail.gmail.com> References: <1241703346.18487.22.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Ronciak, John" , "David S. Miller" , "Waskiewicz Jr, Peter P" To: Jesper Dangaard Brouer Return-path: In-Reply-To: <1241703346.18487.22.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Thu, May 7, 2009 at 6:35 AM, Jesper Dangaard Brouer wrote: > > The following patchset address "drop" stats counters in the igb > driver (chips 82576 and 82575). The drop stats addressed here > are due to the OS cannot keep up. > > I have only tested it for the 82576 chip, as my (12 port) 82575 > chip based NIC from Hotlava Systems recently died in my testlab :-((( > > [First patch] > Implements reading of the per queue drop stats. > These stats only gets incremented if the DROP_EN bit it set (in > the SRRCTL register for that queue, or QDE reg is set). > > [Second patch] > Address the case where the DROP_EN it NOT set. In > this case a global register records the equivalent drop type. And > aggregation of these two types of drops into the device net_stats. > > I strongly believe that these drops counters should be made > available to sysadm's through the normal device stats. These > stats are essential when diagnosing server performance issues, as > these stats are due to the OS cannot keep up. I strongly believe > that it should be stored in the net_stats rx_fifo_errors counter, > to indicate performance issues. > > -- > Med venlig hilsen / Best regards > Jesper Brouer > ComX Networks A/S > Linux Network developer > Cand. Scient Datalog / MSc. > Author of http://adsl-optimizer.dk > LinkedIn: http://www.linkedin.com/in/brouer > Jesper - I have pulled in your patches, and made the necessary modifications based on Mitch's comments. Right now, they are in testing and I should be pushing them to Dave in the next couple of days. -- Cheers, Jeff ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects