netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"e1000-devel@lists.sourceforge.net"
	<e1000-devel@lists.sourceforge.net>,
	"Ronciak, John" <john.ronciak@intel.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH 0/2] igb: drop stats due to OS cannot keep up
Date: Mon, 18 May 2009 00:16:50 -0700	[thread overview]
Message-ID: <9929d2390905180016h4cf065fex51a6b6e061b41792@mail.gmail.com> (raw)
In-Reply-To: <1242373277.8675.8.camel@localhost.localdomain>

On Fri, May 15, 2009 at 12:41 AM, Jesper Dangaard Brouer <hawk@comx.dk> wrote:
> On Thu, 2009-05-14 at 15:43 -0700, Jeff Kirsher wrote:
>> Jesper - I have pulled in your patches, and made the necessary
>> modifications based on Mitch's comments.  Right now, they are in
>> testing and I should be pushing them to Dave in the next couple of
>> days.
>
> Sounds great! :-)
>
> Do you or e1000-devel have a public git tree?
> So I can work off that next time I have some changes, thus it would be
> easier for you to merge in... (this time around I rebased my changes
> each time some of you igb changes got into daveM's net-next-2.6 tree)
>
> Cheers
> --
> Med venlig hilsen / Best regards
>  Jesper Brouer
>  ComX Networks A/S
>  Linux Network developer
>  Cand. Scient Datalog / MSc.
>  Author of http://adsl-optimizer.dk
>  LinkedIn: http://www.linkedin.com/in/brouer

No we do not have a public git tree, but do not worry about it.  Feel
free to send patches, and I can work through most of the issues if any
arise.  So no worries there...

Regarding your patches, during testing we saw a significant difference
in the stats reported by ifconfig versus the stats reported by
ethtool.  Reason being that ethtool stats do not take into account the
RQDPC numbers.  I have been looking at fixing that in the patches, so
while all the testing looks good (except for the difference in
numbers) the patches will be delayed a day or so, while I fix the
ethtool reporting of RQDPC.

-- 
Cheers,
Jeff

      reply	other threads:[~2009-05-18  7:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 13:35 [PATCH 0/2] igb: drop stats due to OS cannot keep up Jesper Dangaard Brouer
2009-05-07 13:37 ` [PATCH 1/2] igb: Implement reading of reg RQDPC (Receive Queue Drop Packet Count) Jesper Dangaard Brouer
2009-05-07 16:06   ` Williams, Mitch A
2009-05-07 19:19     ` Jesper Dangaard Brouer
2009-05-07 19:24       ` Stephen Hemminger
2009-05-11  9:50     ` Jesper Dangaard Brouer
2009-05-13 21:07       ` Williams, Mitch A
2009-05-14  8:03         ` Jesper Dangaard Brouer
2009-05-07 13:38 ` [PATCH 2/2] igb: Record host memory receive overflow in net_stats Jesper Dangaard Brouer
2009-05-14 22:43 ` [PATCH 0/2] igb: drop stats due to OS cannot keep up Jeff Kirsher
2009-05-15  7:41   ` Jesper Dangaard Brouer
2009-05-18  7:16     ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9929d2390905180016h4cf065fex51a6b6e061b41792@mail.gmail.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=hawk@comx.dk \
    --cc=john.ronciak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).