* [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure
@ 2009-05-29 21:16 Mike Mason
2009-06-01 23:43 ` Jeff Kirsher
0 siblings, 1 reply; 3+ messages in thread
From: Mike Mason @ 2009-05-29 21:16 UTC (permalink / raw)
To: netdev
PCI drivers that implement the io_error_detected callback
should return PCI_ERS_RESULT_DISCONNECT if the state
passed in is pci_channel_io_perm_failure. This state is
not checked in many of the network drivers.
This patch fixes the omission in the e1000e driver.
Signed-off-by: Mike Mason <mmlnx@us.ibm.com>
--- a/drivers/net/e1000e/netdev.c 2009-05-23 14:47:00.000000000 -0700
+++ b/drivers/net/e1000e/netdev.c 2009-05-29 13:43:24.000000000 -0700
@@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d
netif_device_detach(netdev);
+ if (state == pci_channel_io_perm_failure)
+ return PCI_ERS_RESULT_DISCONNECT;
+
if (netif_running(netdev))
e1000e_down(adapter);
pci_disable_device(pdev);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure
2009-05-29 21:16 [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure Mike Mason
@ 2009-06-01 23:43 ` Jeff Kirsher
2009-06-02 1:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Kirsher @ 2009-06-01 23:43 UTC (permalink / raw)
To: Mike Mason; +Cc: netdev
On Fri, May 29, 2009 at 2:16 PM, Mike Mason <mmlnx@us.ibm.com> wrote:
> PCI drivers that implement the io_error_detected callback
> should return PCI_ERS_RESULT_DISCONNECT if the state
> passed in is pci_channel_io_perm_failure. This state is not checked in many
> of the network drivers.
>
> This patch fixes the omission in the e1000e driver.
>
> Signed-off-by: Mike Mason <mmlnx@us.ibm.com>
> --- a/drivers/net/e1000e/netdev.c 2009-05-23 14:47:00.000000000 -0700
> +++ b/drivers/net/e1000e/netdev.c 2009-05-29 13:43:24.000000000 -0700
> @@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d
>
> netif_device_detach(netdev);
>
> + if (state == pci_channel_io_perm_failure)
> + return PCI_ERS_RESULT_DISCONNECT;
> +
> if (netif_running(netdev))
> e1000e_down(adapter);
> pci_disable_device(pdev);
>
> --
Looks good.
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
--
Cheers,
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure
2009-06-01 23:43 ` Jeff Kirsher
@ 2009-06-02 1:26 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-06-02 1:26 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: mmlnx, netdev
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 1 Jun 2009 16:43:39 -0700
> On Fri, May 29, 2009 at 2:16 PM, Mike Mason <mmlnx@us.ibm.com> wrote:
>> PCI drivers that implement the io_error_detected callback
>> should return PCI_ERS_RESULT_DISCONNECT if the state
>> passed in is pci_channel_io_perm_failure. This state is not checked in many
>> of the network drivers.
>>
>> This patch fixes the omission in the e1000e driver.
>>
>> Signed-off-by: Mike Mason <mmlnx@us.ibm.com>
>> --- a/drivers/net/e1000e/netdev.c 2009-05-23 14:47:00.000000000 -0700
>> +++ b/drivers/net/e1000e/netdev.c 2009-05-29 13:43:24.000000000 -0700
>> @@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d
>>
>> netif_device_detach(netdev);
>>
>> + if (state == pci_channel_io_perm_failure)
>> + return PCI_ERS_RESULT_DISCONNECT;
>> +
>> if (netif_running(netdev))
>> e1000e_down(adapter);
>> pci_disable_device(pdev);
>>
>> --
>
> Looks good.
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Jeff, can you simply queue this up into the next batch of Intel
driver bits you send to me?
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-02 1:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-29 21:16 [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure Mike Mason
2009-06-01 23:43 ` Jeff Kirsher
2009-06-02 1:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).