From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH net-next-2.6 1/1] e1000e: Expose MDI-X status via ethtool change Date: Wed, 3 Jun 2009 14:31:32 -0700 Message-ID: <9929d2390906031431t44de3203rf35500024af541aa@mail.gmail.com> References: <1243353768.3188.2.camel@achroite> <20090527231542.GA19664@clala-laptop> <1244050462.3191.14.camel@achroite> <4A26B6BC.40605@riverbed.com> <9929d2390906031404j51d9d158i319ba84121212a6e@mail.gmail.com> <4A26E8CF.50700@riverbed.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ben Hutchings , "netdev@vger.kernel.org" To: Chaitanya Lala Return-path: Received: from an-out-0708.google.com ([209.85.132.248]:13401 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbZFCVbb convert rfc822-to-8bit (ORCPT ); Wed, 3 Jun 2009 17:31:31 -0400 Received: by an-out-0708.google.com with SMTP id d40so376239and.1 for ; Wed, 03 Jun 2009 14:31:32 -0700 (PDT) In-Reply-To: <4A26E8CF.50700@riverbed.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jun 3, 2009 at 2:19 PM, Chaitanya Lala wro= te: > Jeff Kirsher wrote: >> >> On Wed, Jun 3, 2009 at 10:45 AM, Chaitanya Lala >> wrote: >> >>> >>> Ben Hutchings wrote: >>> >>>> >>>> On Wed, 2009-05-27 at 16:15 -0700, Chaitanya Lala wrote: >>>> [...] >>>> >>>> >>>>> >>>>> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h >>>>> index 380b042..b553bdb 100644 >>>>> --- a/include/linux/ethtool.h >>>>> +++ b/include/linux/ethtool.h >>>>> @@ -30,7 +30,8 @@ struct ethtool_cmd { >>>>> =C2=A0 =C2=A0 =C2=A0 __u32 =C2=A0 maxtxpkt; =C2=A0 =C2=A0 =C2=A0 = /* Tx pkts before generating tx int */ >>>>> =C2=A0 =C2=A0 =C2=A0 __u32 =C2=A0 maxrxpkt; =C2=A0 =C2=A0 =C2=A0 = /* Rx pkts before generating rx int */ >>>>> =C2=A0 =C2=A0 =C2=A0 __u16 =C2=A0 speed_hi; >>>>> - =C2=A0 =C2=A0 =C2=A0 __u16 =C2=A0 reserved2; >>>>> + =C2=A0 =C2=A0 =C2=A0 __u8 =C2=A0 =C2=A0is_mdix; >>>>> >>>>> >>>> >>>> Since this is specific to Ethernet over=EF=BB=BF twisted-pair cabl= e, could you >>>> please rename this to "eth_tp_mdix". >>>> >>>> >>> >>> Will do for sure. >>> >>>> >>>> >>>>> >>>>> + =C2=A0 =C2=A0 =C2=A0 __u8 =C2=A0 =C2=A0reserved2; >>>>> =C2=A0 =C2=A0 =C2=A0 __u32 =C2=A0 lp_advertising; /* Features the= link partner advertises >>>>> */ >>>>> =C2=A0 =C2=A0 =C2=A0 __u32 =C2=A0 reserved[2]; >>>>> =C2=A0}; >>>>> @@ -632,6 +633,11 @@ struct ethtool_ops { >>>>> =C2=A0#define AUTONEG_DISABLE =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A00x00 >>>>> =C2=A0#define AUTONEG_ENABLE =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x01 >>>>> =C2=A0+/* Mode MDI or MDI-X */ >>>>> +#define MDI_INVALID 0x00 >>>>> +#define MDI =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x01 >>>>> +#define MDI_X =C2=A0 =C2=A0 =C2=A0 0x02 >>>>> >>>>> >>>> >>>> [...] >>>> >>>> Similarly, please add the prefix "ETH_TP_" to these. >>>> >>>> >>> >>> Sure. >>> >> >> Chaitanya, I have made the requested changes to the patch in my tree= =2E >> >> > > Thanks. I am very new to procedure of submitting kernel patches. Just= want > to make sure if this means that I not need to send another patch to n= etdev ? > > Thanks, > Chaitanya > -- When there are changes requested on a patch, yes the patch needs to be re-submitted to netdev. Since I will be pushing this patch along with other patches for Intel drivers to Dave once testing has been completed, there is no need for you to re-submit this patch. I have already sucked in the changes that Ben has requested into the patch that is in my tree. --=20 Cheers, Jeff