From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: hawk@comx.dk, alexander.h.duyck@intel.com, netdev@vger.kernel.org
Subject: Re: [net-next PATCH] igb: update adapter stats when reading /proc/net/dev.
Date: Wed, 13 Jan 2010 19:01:15 -0800 [thread overview]
Message-ID: <9929d2391001131901l402a2b40t7c13205df99abd86@mail.gmail.com> (raw)
In-Reply-To: <20100113.173019.57466924.davem@davemloft.net>
On Wed, Jan 13, 2010 at 17:30, David Miller <davem@davemloft.net> wrote:
> From: Jesper Dangaard Brouer <hawk@comx.dk>
> Date: Tue, 12 Jan 2010 14:41:53 +0100
>
>> Network driver igb: Improve the accuracy of stats in /proc/net/dev, by
>> updating the adapter stats when reading /proc/net/dev. Currently the
>> stats are updated by the watchdog timer every 2 sec, or when getting
>> stats via ethtool -S.
>>
>> A number of userspace apps read these /proc/net/dev stats every second,
>> e.g. ifstat, which then gives a perceived very bursty traffic pattern,
>> which is actually false.
>>
>> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
>
> Intel folks, I assume you guys are going to integrate this.
>
> Thanks.
> --
Correct, I have sucked this into my queue of patches.
--
Cheers,
Jeff
next prev parent reply other threads:[~2010-01-14 3:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 13:41 [net-next PATCH] igb: update adapter stats when reading /proc/net/dev Jesper Dangaard Brouer
2010-01-14 1:30 ` David Miller
2010-01-14 3:01 ` Jeff Kirsher [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-05 14:18 Jesper Dangaard Brouer
2010-10-05 14:41 ` Eric Dumazet
2010-10-05 14:53 ` Jesper Dangaard Brouer
2010-10-05 15:19 ` Eric Dumazet
2010-10-05 21:01 ` Eric Dumazet
2010-10-05 21:16 ` Jesper Dangaard Brouer
2010-10-05 22:34 ` Jeff Kirsher
2010-10-06 3:28 ` Eric Dumazet
2010-10-06 5:47 ` Jeff Kirsher
2010-10-07 6:36 ` David Miller
2010-10-07 6:44 ` Eric Dumazet
2010-10-07 6:46 ` David Miller
2010-10-07 10:06 ` Jesper Dangaard Brouer
2010-10-07 10:24 ` Eric Dumazet
2010-10-07 11:36 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2391001131901l402a2b40t7c13205df99abd86@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=hawk@comx.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).