From: Thomas Huth <thuth@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Steve French <smfrench@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 3/6] net/tcp-ao: clear the aes_cmac_key when done
Date: Sat, 8 Aug 2026 12:38:57 +0200 [thread overview]
Message-ID: <995329a7-8980-4b5c-85c1-9c415b200804@redhat.com> (raw)
In-Reply-To: <20260807152231.15b33daf@kernel.org>
On 08/08/2026 00.22, Jakub Kicinski wrote:
> On Fri, 7 Aug 2026 14:58:40 +0200 Thomas Huth wrote:
>> - struct aes_cmac_key k;
>> + struct aes_cmac_key k __cleanup(aes_cmac_zeroize_key);
>
> Nak, we don't like the auto-cleanup stuff in networking.
Ok, if you don't like it, then let's drop this patch.
> If y'all need a garbage collector there're jobs programming in Java.
No need for derogatory statements, Jakub. That's really inappropriate.
Thomas
prev parent reply other threads:[~2026-08-08 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260807125845.1477067-1-thuth@redhat.com>
2026-08-07 12:58 ` [PATCH v2 3/6] net/tcp-ao: clear the aes_cmac_key when done Thomas Huth
2026-08-07 22:22 ` Jakub Kicinski
2026-08-08 10:38 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995329a7-8980-4b5c-85c1-9c415b200804@redhat.com \
--to=thuth@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linkinjeon@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox