From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: [PATCH 3/3] sh_eth: use DIV_ROUND_UP() in sh_eth_soft_swap() Date: Sat, 2 Jun 2018 22:40:16 +0300 Message-ID: <995798f8-69e0-6471-8eca-eefc420dbe21@cogentembedded.com> References: <9027499a-0e19-7721-a17f-26e86885da3f@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-renesas-soc@vger.kernel.org To: netdev@vger.kernel.org, "David S. Miller" Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:39424 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbeFBTkT (ORCPT ); Sat, 2 Jun 2018 15:40:19 -0400 Received: by mail-lf0-f68.google.com with SMTP id t134-v6so19496016lff.6 for ; Sat, 02 Jun 2018 12:40:19 -0700 (PDT) In-Reply-To: <9027499a-0e19-7721-a17f-26e86885da3f@cogentembedded.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: When initializing 'maxp' in sh_eth_soft_swap(), the buffer length needs to be rounded up -- that's just asking for DIV_ROUND_UP()! Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -464,7 +464,7 @@ static void sh_eth_soft_swap(char *src, { #ifdef __LITTLE_ENDIAN u32 *p = (u32 *)src; - u32 *maxp = p + ((len + sizeof(u32) - 1) / sizeof(u32)); + u32 *maxp = p + DIV_ROUND_UP(len, sizeof(u32)); for (; p < maxp; p++) *p = swab32(*p);