Netdev List
 help / color / mirror / Atom feed
From: "Zhu, Lingshan" <lingshan.zhu@intel.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: jasowang@redhat.com, mst@redhat.com,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ifcvf/vDPA: fix misuse virtio-net device config size for blk dev
Date: Wed, 1 Dec 2021 10:36:42 +0800	[thread overview]
Message-ID: <9957a8be-f93a-5d23-d697-22968f31766f@intel.com> (raw)
In-Reply-To: <20211130093228.iiz2r43e7mcgecnk@steredhat>



On 11/30/2021 5:32 PM, Stefano Garzarella wrote:
> On Mon, Nov 29, 2021 at 05:31:44PM +0800, Zhu Lingshan wrote:
>> This commit fixes a misuse of virtio-net device config size issue
>> for virtio-block devices.
>>
>> A new member config_size in struct ifcvf_hw is introduced and would
>> be initialized through vdpa_dev_add() to record correct device
>> config size.
>>
>> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
>> Reported-and-suggested-by: Stefano Garzarella <sgarzare@redhat.com>
>> Fixes: 6ad31d162a4e ("vDPA/ifcvf: enable Intel C5000X-PL virtio-block 
>> for vDPA")
>> Cc: <stable@vger.kernel.org>
>> ---
>> drivers/vdpa/ifcvf/ifcvf_base.c | 41 +++++++++++++++++++++++++--------
>> drivers/vdpa/ifcvf/ifcvf_base.h |  9 +++++---
>> drivers/vdpa/ifcvf/ifcvf_main.c | 24 ++++---------------
>> 3 files changed, 41 insertions(+), 33 deletions(-)
>
> The patch LGTM. Maybe we could add in the description that we rename 
> some fields and functions in a more generic way.
Sure, Thanks!

Thanks,
Zhu Lingshan
>
> In both cases:
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
> Thanks,
> Stefano
>


      reply	other threads:[~2021-12-01  2:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  9:31 [PATCH] ifcvf/vDPA: fix misuse virtio-net device config size for blk dev Zhu Lingshan
2021-11-30  9:32 ` Stefano Garzarella
2021-12-01  2:36   ` Zhu, Lingshan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9957a8be-f93a-5d23-d697-22968f31766f@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox