From: David Ahern <dsahern@gmail.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>, netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel
Date: Sun, 25 Aug 2019 10:23:08 -0600 [thread overview]
Message-ID: <99662602-8125-a400-fa36-178b01dcc824@gmail.com> (raw)
In-Reply-To: <1566582703-26567-1-git-send-email-alexey.kodanev@oracle.com>
On 8/23/19 11:51 AM, Alexey Kodanev wrote:
> When using mpls over gre/gre6 setup, rt->rt_gw4 address is not set, the
> same for rt->rt_gw_family. Therefore, when rt->rt_gw_family is checked
> in mpls_xmit(), neigh_xmit() call is skipped. As a result, such setup
> doesn't work anymore.
>
> This issue was found with LTP mpls03 tests.
>
> Fixes: 1550c171935d ("ipv4: Prepare rtable for IPv6 gateway")
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
> net/mpls/mpls_iptunnel.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
ok, I see now. This is a device only route with MPLS encap:
10.23.0.1 encap mpls 60 dev ltp_v0 scope link
and the change reverts to 5.1 behavior unless the gateway is IPv6 (new
behavior). Thanks for the patch.
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2019-08-25 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 17:51 [PATCH net] ipv4: mpls: fix mpls_xmit for iptunnel Alexey Kodanev
2019-08-23 17:59 ` David Ahern
2019-08-23 22:12 ` David Miller
2019-08-25 16:23 ` David Ahern [this message]
2019-08-25 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99662602-8125-a400-fa36-178b01dcc824@gmail.com \
--to=dsahern@gmail.com \
--cc=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox