From: Lucas Stach <l.stach@pengutronix.de>
To: "Jisheng Zhang" <jszhang@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Samuel Holland <samuel@sholland.org>,
netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Eric Dumazet <edumazet@google.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-sunxi@lists.linux.dev,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue 64 bit statistics where necessary
Date: Tue, 12 Sep 2023 11:04:16 +0200 [thread overview]
Message-ID: <99695befef06b025de2c457ea5f861aa81a0883c.camel@pengutronix.de> (raw)
In-Reply-To: <ZQAa3277GC4c9W1D@xhacker>
Am Dienstag, dem 12.09.2023 um 16:01 +0800 schrieb Jisheng Zhang:
> On Mon, Sep 11, 2023 at 07:11:02PM +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > this patch became commit 133466c3bbe171f826294161db203f7670bb30c8 and is
> > part of v6.6-rc1.
> >
> > On my arm/stm32mp157 based machine using NFS root this commit makes the
> > following appear in the kernel log:
> >
> > INFO: trying to register non-static key.
> > The code is fine but needs lockdep annotation, or maybe
> > you didn't initialize this object before use?
> > turning off the locking correctness validator.
> > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc1-00449-g133466c3bbe1-dirty #21
> > Hardware name: STM32 (Device Tree Support)
> > unwind_backtrace from show_stack+0x18/0x1c
> > show_stack from dump_stack_lvl+0x60/0x90
> > dump_stack_lvl from register_lock_class+0x98c/0x99c
> > register_lock_class from __lock_acquire+0x74/0x293c
> > __lock_acquire from lock_acquire+0x134/0x398
> > lock_acquire from stmmac_get_stats64+0x2ac/0x2fc
> > stmmac_get_stats64 from dev_get_stats+0x44/0x130
> > dev_get_stats from rtnl_fill_stats+0x38/0x120
> > rtnl_fill_stats from rtnl_fill_ifinfo+0x834/0x17f4
> > rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xc0/0x144
> > rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x50/0x88
> > rtmsg_ifinfo from __dev_notify_flags+0xc0/0xec
> > __dev_notify_flags from dev_change_flags+0x50/0x5c
> > dev_change_flags from ip_auto_config+0x2f4/0x1260
> > ip_auto_config from do_one_initcall+0x70/0x35c
> > do_one_initcall from kernel_init_freeable+0x2ac/0x308
> > kernel_init_freeable from kernel_init+0x1c/0x138
> > kernel_init from ret_from_fork+0x14/0x2c
> > Exception stack(0xe0815fb0 to 0xe0815ff8)
> > 5fa0: 00000000 00000000 00000000 00000000
> > 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> > 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> > dwc2 49000000.usb-otg: new device is high-speed
> >
> > I didn't try understand this problem, it's too close to quitting time
> > :-)
>
> Thanks for the bug report, I'm checking the code.
The newly added "struct u64_stats_sync syncp" uses a seqlock
internally, which is broken into multiple words on 32bit machines, and
needs to be initialized properly. You need to call u64_stats_init on
syncp before first usage.
Regards,
Lucas
> >
> > Best regards
> > Uwe
> >
> > --
> > Pengutronix e.K. | Uwe Kleine-König |
> > Industrial Linux Solutions | https://www.pengutronix.de/ |
>
>
>
next prev parent reply other threads:[~2023-09-12 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:06 [PATCH net-next v5 0/2] net: stmmac: improve driver statistics Jisheng Zhang
2023-07-17 16:06 ` [PATCH net-next v5 1/2] net: stmmac: don't clear network statistics in .ndo_open() Jisheng Zhang
2023-07-17 16:06 ` [PATCH net-next v5 2/2] net: stmmac: use per-queue 64 bit statistics where necessary Jisheng Zhang
2023-09-11 17:11 ` [REGRESSION] " Uwe Kleine-König
2023-09-12 8:01 ` Jisheng Zhang
2023-09-12 9:04 ` Lucas Stach [this message]
2023-09-12 9:24 ` Uwe Kleine-König
2023-09-12 9:30 ` Johannes Berg
2023-09-13 14:34 ` Jisheng Zhang
2023-09-13 14:49 ` Johannes Berg
2023-09-13 20:12 ` Uwe Kleine-König
2023-09-12 8:23 ` Jisheng Zhang
2023-09-12 9:26 ` Uwe Kleine-König
2023-09-21 18:34 ` Guenter Roeck
2023-09-21 19:56 ` Uwe Kleine-König
2023-09-21 20:14 ` Guenter Roeck
2023-07-19 1:01 ` [PATCH net-next v5 0/2] net: stmmac: improve driver statistics Jakub Kicinski
2023-07-20 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99695befef06b025de2c457ea5f861aa81a0883c.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=joabreu@synopsys.com \
--cc=jszhang@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).