From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794830287; b=HSq1TBYYcFAoqq3qFpdEIT6fJlc+G/HZ64LI/Yy2X8R4Ogy4U8jcDdzgPjs5tXiGgEwZ rzEqRP8sxauoCikieUmWK6ohPTi0cxHXze0mJkt0NliDovB6arKXn7mA4Nx5uisQ1G3rU evPjve4smMwqJoHQDvhYCVgYpKe2tKzqFmxGPMhuGmMmexAEQvfhkm9Y0lxdGUKVbMcEe 1dTmbPQ9S4mRYU/GkhwfWSRLONkhG/RIOTBAlJituT8VEqyyMAZnXUGbvC6QhzUSHuRQf /S6DSpTkFU0J6O4afKouFduyU3lM1q/QAT8yHvP79y4nl/WiHshzAJDfdUbI6A/IjZw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794830287; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:Content-Language:To:Cc:References:From:Autocrypt:Organization: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=CT0k0qaGom0emmcyhnGmC3Zz4iYrJsSIXC3R0FJ/rw0=; b=CjVkusx7a0GVtlqR1F8aiOLjPzpYevB8qSnqnRF9r5IMh8WwfVDIX/EkzlyqlzPD+8W7 6zDEjhvS70YT9EYoa8qzSBQaFBfN0/oUBHJ12FmRq/LqUxjdHR/ZhvtRw3MNOwWN8iJbC 5L+1gFoVU5RVETK2SylnLqN75rwyBWlA7GRqqNAfDy1fuzNWkDMvsaeezEFIf3JP9z5rb s//TodnwOJgMEyIpJPA2wIJeudD36HTNBE84s1gQCO6252S5mBmwyaNyhcwcWWw6jnelw wcz22Rv3OvqJGiO9Zg/71JojAPsbtSbX/SLZTZ9QuOCJd+K9Ep1WgH+U5Nz7Z4iI2jQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=emQO84hB; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F6A4606A335; Mon, 16 Nov 2026 11:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=emQO84hB Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C8381F000C4; Mon, 16 Nov 2026 11:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794830286; bh=CT0k0qaGom0emmcyhnGmC3Zz4iYrJsSIXC3R0FJ/rw0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=emQO84hB0whhXw99h+HdACi9fEU/JaLprbnTNo96M21MSP86/z4OZAZtl1pJMrlST ES4gzvL+MKmjEUmoBloO+aouLZoQJrSVYOdoUcTr8EPC2Pih8Cwcsmnv2W7kOjAD6j qnClb+5djsuPVGOlxp8q21o/0hPtiK2aCvIsvYqGsbSMoI1nbIqPpKJhAR5At6J1eu aKX/GN+n0TfvmmaCoIn0aptz+vOSLLHYl5KznwlYw4omOypIa7wCrHsrj0Ndgi4xwH zf7psDDcoXjIhXlKNHT3WBtVDy3+UiGosmbLucRg6m9y7eQRzwzXn9XU50/CHuKdiE w/Z8ARFsXM5WA== Message-ID: <998d522f-e61d-420f-9834-6bdcbaab1361@kernel.org> Date: Mon, 16 Nov 2026 12:58:01 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change Content-Language: fr To: Minxi Hou Cc: netdev@vger.kernel.org, Aaron Conole , Eelco Chaudron , Ilya Maximets , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , linux-kselftest@vger.kernel.org References: <20261115163134.3202677-1-houminxi@gmail.com> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20261115163134.3202677-1-houminxi@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Minxi, On 15/11/2026 17:31, Minxi Hou wrote: > The datapath records the user features before it applies the change, so > a request that fails leaves it claiming a bit whose reference count was > never taken. The first patch records the features last. The second adds a > selftest that drives the failing request and reads back what the datapath > reports. > > v4: > - Rebased onto current main. > - The skip message is one printf again. Splitting it made shellcheck > report SC2182 and dropped a word and the newline from the output. > - The new tests say why they failed on stdout. info() writes debug.log > and a failing run deletes that file, so CI showed a FAIL with no reason. > - A datapath that cannot be read is reported as that instead of as a > feature mismatch. > - The outdated add-dp request is checked instead of discarded. > - The errno numbers come from python rather than from a literal, and a > lookup that cannot answer says so rather than comparing against an > empty string. Thank you for the new version, but I suspect this series caused troubles on the CI side: it looks like openvswitch.sh hangs/times out after all subtests pass. # TEST: psample [START] # TEST: psample: Sampling packets with psample [ OK ] => then nothing for 10 minutes, instead of: ok 1 selftests: net/openvswitch: openvswitch.sh How did you validate this series? Note that the Netdev CI, for this specific case, combines 'config' files from net, net/af_unix net/openvswitch: tools/testing/selftests/net/config tools/testing/selftests/net/af_unix/config tools/testing/selftests/net/openvswitch/config Cheers, Matt